feat(core): adds angular 20 support #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created a new `karma.conf.js` file to configure Karma for testing. - Integrated Jasmine framework and Angular DevKit for testing support. - Added plugins for Chrome launcher, coverage reporting, and HTML reporting. - Configured coverage reporter to output results in the `./coverage/ng-kit` directory. - Set up reporters for progress and Jasmine HTML output. - Enabled automatic restart on file changes during testing.
…ipleClicksDirective
…simplify initialization
…roved functionality and code clarity
…d functionality and usability
✅ Deploy Preview for ng-kit ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the project’s Angular dependencies from version 19 to 20 while also refactoring a few components to adopt newer Angular features and improved type safety.
- Removed deprecated test setup code
- Applied explicit type annotations and updated component imports
- Adjusted configuration files (package.json, angular.json, ESLint) and documentation for Angular 20 support
Reviewed Changes
Copilot reviewed 54 out of 54 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| projects/ng-kit-demo/src/test-setup.ts | Removed jest preset import for testing setup |
| projects/ng-kit-demo/src/app/snack-bar-demo/snack-bar-demo.component.ts | Minor template formatting fix |
| projects/ng-kit-demo/src/app/progress-state-demo/progress-state-demo.component.ts | Added OnPush change detection; removed CommonModule import |
| projects/ng-kit-demo/src/app/progress-state-demo/progress-state-demo.component.html | Updated Angular control flow syntax (@if) |
| projects/ng-kit-demo/src/app/edit-svg-icon-demo/edit-svg-icon-demo.component.ts | Minor styles formatting update |
| projects/ng-kit-demo/src/app/directives-demo/directives-demo.component.ts | Added explicit type annotation for click() method |
| projects/ng-kit-demo/src/app/buttons-demo/buttons-demo.component.ts | Added type annotations and renamed unused parameter |
| projects/ng-kit-demo/src/app/autocomplete-demo/autocomplete-demo.component.ts & .html | Formatting updates and minor refactoring in display logic |
| projects/ng-kit-demo/src/app/app.config.ts | Updated and reordered imports |
| projects/ng-kit-demo/src/app/app.component.ts | Minor formatting update |
| projects/ng-kit-demo/src/app/alert-demo/alert-demo.component.ts | Minor formatting update |
| projects/ng-kit-demo/eslint.config.js | Added updated ESLint configuration for TS and HTML |
| projects/ng-kit-demo/.eslintrc.json | Removed redundant ESLint configuration |
| package.json | Upgraded Angular packages from 19 to 20 and updated devDependencies |
| eslint.config.js | Added updated ESLint configuration |
| angular.json | Added schematics configuration for Angular components |
| README.md | Updated build instructions from nx to pnpm |
| .github/copilot-instructions.md | Updated instructions; note discrepancy in Angular version |
| .eslintrc.json | Removed obsolete configuration file |
Comments suppressed due to low confidence (2)
projects/ng-kit-demo/src/test-setup.ts:1
- The removal of the Jest preset import may affect test configuration if Jest is still being used. Please verify that the testing environment is configured properly after this change.
import 'jest-preset-angular/setup-jest';
projects/ng-kit-demo/src/app/progress-state-demo/progress-state-demo.component.ts:7
- The removal of CommonModule from the component's imports should be confirmed as intentional, ensuring that all necessary directives (e.g. ngIf in templates) remain available via alternative global imports or Angular's new control flow features.
imports: [CommonModule, SavePrimaryButtonComponent, AlertComponent],
| @@ -1,5 +1,7 @@ | |||
| We use latest Angular and TypeScript for our angular development. Always show examples and reference the latest version of Angular and TypeScript in your responses. If in doubt, use docs from https://angular.dev/overview | |||
| Always use latest Angular (at present 19) version and TypeScript for our angular development. Always show examples and reference the latest version of Angular in your responses. If in doubt, use docs from https://angular.dev/overview | |||
There was a problem hiding this comment.
Since this PR upgrades Angular to version 20, update the instruction to reflect Angular 20 to avoid confusion for future development.
Copilot uses AI. Check for mistakes.
|
🎉 This PR is included in version 19.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.