-
Notifications
You must be signed in to change notification settings - Fork 83
OpenSSL 1.1.1 cert verification port #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deprecated ones are for the current (legacy) verify_chain
an attempt to retrofit verification to consider alt-chains
4 tasks
due test fails but we're still plan using the new time checks
this should be fine since it just does more checks
28d5106
to
42a4b6a
Compare
This was referenced Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an attempt to port over
verify_chain
(build_chain
) and all related bits from OpenSSL 1.1.1.JOSSL current certificate verification algorithm is rather straightforward and dates back to OpenSSL 0.9 days.
Several times we tried porting over newer code to enhance verification (e.g. to consider alternate chains) but failed due the magnitude of the task.
The PR is an attempt for a minimal viable product in terms of OpenSSL 1.1.1 compatible chain verification.
No relevant security features should be missing - if so than they are likely not present in the legacy algorithm as well.
The WiP here skips dane support completely (as well as a few other parts) - full port is far from complete.
There's also a number of (OpenSSL 1.1.1) features which are slightly changed or disabled :
EXFLAG_SS
isn't working - switched cert_self_signed to only checkEXFLAG_SI
EXFLAG_XXX
checks to do less work?check_chain_extension
ENV['OPENSSL_ALLOW_PROXY_CERTS']
check_cert
checking not ported - using old legacy checkscurrent_crl_score
andcurrent_reasons
?auth_level
checkscheck_id