Still some illegal reflective access warnings

[deivid-rodriguez]

I'm still getting some illegal reflective access warnings, even when using the current head version of jruby-openssl.

The warnings read like this:

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.jruby.ext.openssl.SecurityHelper (file:/home/deivid/.rbenv/versions/jruby-9.2.11.0/lib/ruby/gems/shared/gems/jruby-openssl-0.10.5.dev-java/lib/jopenssl.jar) to constructor java.security.KeyFactory(java.security.KeyFactorySpi,java.security.Provider,java.lang.String)
WARNING: Please consider reporting this to the maintainers of org.jruby.ext.openssl.SecurityHelper
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

I can reproduce these warnings by running rubygems test suite with jruby under a Linux environment using java 11.

[headius]

Is $JAVA_HOME set?

[headius]

Oh nevermind...this looks like a new case I did not know about.

[headius]

Fixed for next release.

[deivid-rodriguez]

Nice, thanks! Just tried it and it works! No warnings finally :)

[deivid-rodriguez]

Actually headius, no more warnings on every boot, but there's still one warning when running rubygems tests with jruby on java 11:

$ rake
Skipping `gem cert` tests on jruby.
Skipping Gem::Security tests on jruby.
Run options: --seed 35101

# Running:

....	...............................................S..........S.....................................................................WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.jruby.ext.openssl.SecurityHelper (file:/home/deivid/.rbenv/versions/jruby-9.2.11.1/lib/ruby/gems/shared/gems/jruby-openssl-0.10.5.dev-java/lib/jopenssl.jar) to constructor java.security.Signature$Delegate(java.security.SignatureSpi,java.lang.String)
WARNING: Please consider reporting this to the maintainers of org.jruby.ext.openssl.SecurityHelper
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
.......S...............S.......................................................S...........S........S.....S.........S.............S....S..........SS....S....................................................................SS..S....................S.SS.............................................................................................................SSS..................S.........................S......................................................S............................S......S.............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................S.........................S.......................................................................................................................................................................................................S.............S....S.............S......................................S....................................S.......S.................S..............S..............S......./home/deivid/Code/rubygems/lib/rubygems/util.rb:67: warning: system does not support options in JRuby yet: {:out=>"/dev/null", :err=>[:child, :out]}
/home/deivid/Code/rubygems/lib/rubygems/util.rb:67: warning: system does not support options in JRuby yet: {:out=>"/dev/null", :err=>[:child, :out]}
.......................................................................................................S...................................................................S....................................................................................................................................................................................................................................................S...........................................................................

Finished in 597.769757s, 3.3960 runs/s, 10.3250 assertions/s.

2030 runs, 6172 assertions, 0 failures, 0 errors, 43 skips

You have skipped tests. Run with --verbose for details.

In particular, it's this test:

$ rake TESTOPTS=--name=TestGemRemoteFetcher#test_fetch_s3_config_creds_with_token
Skipping `gem cert` tests on jruby.
Skipping Gem::Security tests on jruby.
Run options: --name=TestGemRemoteFetcher#test_fetch_s3_config_creds_with_token --seed 16229

# Running:

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.jruby.ext.openssl.SecurityHelper (file:/home/deivid/.rbenv/versions/jruby-9.2.11.1/lib/ruby/gems/shared/gems/jruby-openssl-0.10.5.dev-java/lib/jopenssl.jar) to constructor javax.crypto.Mac(javax.crypto.MacSpi,java.security.Provider,java.lang.String)
WARNING: Please consider reporting this to the maintainers of org.jruby.ext.openssl.SecurityHelper
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
.

Finished in 1.057450s, 0.9457 runs/s, 1.8913 assertions/s.

1 runs, 2 assertions, 0 failures, 0 errors, 0 skips

[headius]

@deivid-rodriguez I see something similar from time to time. jruby-openssl needs to either avoid using reflection in these cases (usually possible) or use the same mechanism that JRuby uses (attempt to set the module to be open before accessing it). The latter is a quick fix.

[deivid-rodriguez]

I just tried latest master, including 7c4591c, and it worked 🎉

$ rake TESTOPTS=--name=TestGemRemoteFetcher#test_fetch_s3_config_creds_with_token
Skipping `gem cert` tests on jruby.
Skipping Gem::Security tests on jruby.
Run options: --name=TestGemRemoteFetcher#test_fetch_s3_config_creds_with_token --seed 34628

# Running:

.

Finished in 0.352286s, 2.8386 runs/s, 5.6772 assertions/s.
1 runs, 2 assertions, 0 failures, 0 errors, 0 skips
Coverage report generated for Unit Tests to /home/deivid/Code/rubygems/rubygems/coverage. 2374 / 8903 LOC (26.67%) covered.

Thanks!