Add support for unit formatting#15
Merged
jrmajor merged 17 commits intojrmajor:masterfrom Jun 23, 2023
Merged
Conversation
Contributor
hakastein
commented
Jun 6, 2023
hakastein
commented
- Add units exporter, parser and etc
- Add units support no NumberFormatter.php
- LocaleKnownValuesTest.php redesigned
Contributor
Author
|
There somthing strange with style check. Ill run |
Owner
|
Please try running |
Contributor
Author
|
Ah, so obviusly. Thx |
jrmajor
force-pushed
the
feature/units-support
branch
from
9eb8cdd to
c459fba
Compare
Contributor
Author
|
Original list copied from ecma402 source codes, to facilitate future changes https://unpkg.com/browse/@formatjs/ecma402-abstract@1.11.7/IsSanctionedSimpleUnitIdentifier.js |
- do not generate data for und locale, because all locales have data for all units - do not include displayName and perUnit, because they are not used
Owner
|
Thank you, @hakastein! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.