-
Notifications
You must be signed in to change notification settings - Fork 80
Targeted Recording Stop: Track Child PID and Kill Only That Process #20
Copy link
Copy link
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Description
🧐 What & Why
stop_recording uses
pkill -SIGINT -f "simctl.*recordVideo"This can terminate other users’ or unrelated simctl recordVideo sessions, causing data loss and confusion.
🛠️ Proposal
- When spawning
xcrun … recordVideo, capture the returnedChildProcessobject and storechild.pidin aMapkeyed by UDID (or a singleton if only one recording allowed). - Replace
pkillwithprocess.kill(savedPid, 'SIGINT'). - If no PID is stored, return an error:
No recording is currently running.
✅ Acceptance Criteria
-
record_videosaves its own PID. -
stop_recordingsignals only that PID. - Unit tests verify PID storage and targeted kill.
- Legacy
pkillcode removed.
⚠️ Notes
If multiple recordings per UDID are later supported, extend the map to hold arrays of PIDs.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request