[web] Migrate Flutter Web DOM usage to JS static interop - 2 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshualitt
pushed a commit
that referenced
this pull request
Jul 10, 2023
…visions) (flutter#43457)" (flutter#43466) This reverts commit a109e0b as it breaks flutter framework tests during subsequent roll. From flutter/flutter#130138: _TypeError: (#0 _ProgramInfoBuilder.createInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:450:53)) ``` #0 _ProgramInfoBuilder.createInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:450:53) #1 _ProgramInfoBuilder.getInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:374:14) #2 _ProgramInfoBuilder.createInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:444:23) #3 _ProgramInfoBuilder.getInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:374:14) #4 _ProgramInfoBuilder.createInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:419:54) #5 _ProgramInfoBuilder.getInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:374:14) #6 ListIterable.forEach (dart:_internal/iterable.dart:39:13) #7 _ProgramInfoBuilder.build (package:vm_snapshot_analysis/v8_profile.dart:338:16) #8 toProgramInfo (package:vm_snapshot_analysis/v8_profile.dart:282:8) #9 _treemapFromSnapshot (package:vm_snapshot_analysis/treemap.dart:158:27) #10 treemapFromJson (package:vm_snapshot_analysis/treemap.dart:85:5) #11 SizeAnalyzer.analyzeZipSizeAndAotSnapshot (package:flutter_tools/src/base/analyze_size.dart:123:59) #12 AndroidGradleBuilder._performCodeSizeAnalysis (package:flutter_tools/src/android/gradle.dart:623:60) #13 AndroidGradleBuilder.buildGradleApp (package:flutter_tools/src/android/gradle.dart:604:15) <asynchronous suspension> #14 AndroidGradleBuilder.buildApk (package:flutter_tools/src/android/gradle.dart:242:5) <asynchronous suspension> #15 BuildApkCommand.runCommand (package:flutter_tools/src/commands/build_apk.dart:116:5) <asynchronous suspension> #16 FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1297:27) <asynchronous suspension> #17 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19) <asynchronous suspension> #18 CommandRunner.runCommand (package:args/command_runner.dart:212:13) <asynchronous suspension> ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is CL 2 in a series of CLs to migrate Flutter Web DOM usage to the new JS static interop API.
Note: Because we have not quite finished the new DOM library based on JS static interop, this CL introduces a shim library which should mostly match the forthcoming API. A subsequent much smaller migration will occur once the new library is complete.