Windows newline/backslashes BadRequest fix#13
Merged
josephwoodward merged 3 commits intojosephwoodward:masterfrom Jun 11, 2020
stephen-moyer:sm/newline-windows-badrequest-fix
Merged
Windows newline/backslashes BadRequest fix#13josephwoodward merged 3 commits intojosephwoodward:masterfrom stephen-moyer:sm/newline-windows-badrequest-fix
josephwoodward merged 3 commits intojosephwoodward:masterfrom
stephen-moyer:sm/newline-windows-badrequest-fix
Conversation
stephen-moyer
changed the title
Owner
|
@steveadoo32 Great, thanks for fixing this! |
bradacina
pushed a commit
to bradacina/Serilog-Sinks-Loki
that referenced
this pull request
Jul 8, 2020
…ows-badrequest-fix Windows newline/backslashes BadRequest fix
|
Thank you for fixing this! We have been having the same problem. Most of our logs were lost because of this. When can we expect a new nuget release with those fixes? |
Owner
|
This has now been release as part of the 2.2.0 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #12
StringBuilder on windows uses '\r\n' for new lines, which Loki doesn't like.
Loki also doesn't like backslashes '\', so I flip them to forward slashes.