Use Codecov CLI instead of Uploader#42
Merged
joscha merged 1 commit intojoscha:masterfrom Oct 8, 2024
Merged
Conversation
Contributor
Author
|
@joscha whenever you got a minute, please take a look at this PR 🙏 The changes are minimal. |
Owner
|
Thank you! |
Owner
|
not sure why https://github.com/apps/boomper-bot hasn't updated the README.md, yet, we'll give it a bit more time. |
Contributor
Author
|
@joscha I'm adding the args and config we use for posterity. Feel free to add that to the docs if needed (as an example): |
paymand
commented
Oct 8, 2024
| get_codecov_cli() { | ||
| case "${OS}" in | ||
| alpine|linux|macos) | ||
| alpine|alpine-64|linux|linux-64|macos) |
Contributor
Author
There was a problem hiding this comment.
@joscha oops, I made a mistake here 😢 s/64/arm64
Owner
|
Do you want to update the readme as well with a 4.0.1 please? I don't think Boomper is working anymore |
Contributor
Author
|
@joscha I'll update README + fix the typo in a new PR |
Contributor
Author
|
Updating README here: #43 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codecov uploader is deprecated and the recommended tool to use is Codecov CLI. Binaries can be download from https://cli.codecov.io.
I've tested and this works fine on our CI.
We'll however need to release this as major because it has breaking changes: for example: I'm renaming
uploader_versiontocli_version. Also, you need to send inupload-processin args.