Skip to content

Use Codecov CLI instead of Uploader#42

Merged
joscha merged 1 commit intojoscha:masterfrom
peakon:payman/codecov_cli
Oct 8, 2024
Merged

Use Codecov CLI instead of Uploader#42
joscha merged 1 commit intojoscha:masterfrom
peakon:payman/codecov_cli

Conversation

@paymand
Copy link
Copy Markdown
Contributor

@paymand paymand commented Oct 8, 2024

Codecov uploader is deprecated and the recommended tool to use is Codecov CLI. Binaries can be download from https://cli.codecov.io.
I've tested and this works fine on our CI.
We'll however need to release this as major because it has breaking changes: for example: I'm renaming uploader_version to cli_version. Also, you need to send in upload-process in args.

@paymand
Copy link
Copy Markdown
Contributor Author

paymand commented Oct 8, 2024

@joscha whenever you got a minute, please take a look at this PR 🙏 The changes are minimal.

@joscha joscha merged commit dfbd626 into joscha:master Oct 8, 2024
@joscha
Copy link
Copy Markdown
Owner

joscha commented Oct 8, 2024

Thank you!

@joscha
Copy link
Copy Markdown
Owner

joscha commented Oct 8, 2024

not sure why https://github.com/apps/boomper-bot hasn't updated the README.md, yet, we'll give it a bit more time.

@paymand
Copy link
Copy Markdown
Contributor Author

paymand commented Oct 8, 2024

@joscha I'm adding the args and config we use for posterity. Feel free to add that to the docs if needed (as an example):

  - &codecov_plugin
    joscha/codecov#v4.0.0:
      skip_on_fail: true
      args:
        - '--auto-load-params-from=Buildkite'
        - '--verbose'
        - 'upload-process'
        - '-F $$BUILDKITE_JOB_ID'
        - '-r $BUILDKITE_ORGANIZATION_SLUG/$BUILDKITE_PIPELINE_NAME'
        - '--git-service=$BUILDKITE_PIPELINE_PROVIDER'
      docker_image: 'public.ecr.aws/docker/library/buildpack-deps:noble-scm'
      cli_version: v0.7.5

get_codecov_cli() {
case "${OS}" in
alpine|linux|macos)
alpine|alpine-64|linux|linux-64|macos)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joscha oops, I made a mistake here 😢 s/64/arm64

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo fix here: #43

@joscha
Copy link
Copy Markdown
Owner

joscha commented Oct 8, 2024

Do you want to update the readme as well with a 4.0.1 please? I don't think Boomper is working anymore

@paymand
Copy link
Copy Markdown
Contributor Author

paymand commented Oct 8, 2024

@joscha I'll update README + fix the typo in a new PR

@paymand
Copy link
Copy Markdown
Contributor Author

paymand commented Oct 8, 2024

Updating README here: #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants