Skip to content

Fix error handling for parsed output - #23

Merged
jonnylangefeld merged 2 commits into
masterfrom
jlf/correct-error-handling
Dec 17, 2021
Merged

Fix error handling for parsed output#23
jonnylangefeld merged 2 commits into
masterfrom
jlf/correct-error-handling

Conversation

@jonnylangefeld

Copy link
Copy Markdown
Owner

parsed outputs always failed because the output string was empty.
Now we don't even add the output to the map in case of an error, but we write it to the debug output.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #23 (67c74b2) into master (a3d5745) will decrease coverage by 0.78%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   82.97%   82.19%   -0.79%     
==========================================
  Files           1        1              
  Lines         141      146       +5     
==========================================
+ Hits          117      120       +3     
- Misses         13       14       +1     
- Partials       11       12       +1     
Impacted Files Coverage Δ
pkg/mc/mc.go 82.19% <83.33%> (-0.79%) ⬇️

@jonnylangefeld
jonnylangefeld merged commit 8b63ba8 into master Dec 17, 2021
@jonnylangefeld
jonnylangefeld deleted the jlf/correct-error-handling branch December 17, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants