(Android) Fix UTF-8 related crashes #353
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://developer.android.com/reference/java/nio/charset/Charset.html#defaultCharset()
Before this change, the following Exception would be thrown when streaming a file containing Arabic characters:
Fixes: #297
Gave it a quick manual test a json file containing Arabic using:
and the json was logged correctly.
For the file stream change, again I tested this manually with a of react-native-local-mongodb I'm working on which loads data from files. Occasionally with a large enough file the app can hit OOM so I'm introducing streaming to reduce the likelihood of this. After this change the app now loads again.