Fix Snapmaker Luban support #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the latest version of Luban the formatting has changed slightly. This adds Luban support back. This will only work with newly sliced gcodes.
Owner
|
Could you do me a favor and validate the change I just committed to your PR, which should allow for both use cases?
|
Golumpa
commented
Feb 8, 2024
Contributor
Author
Golumpa
left a comment
Golumpa
left a comment
There was a problem hiding this comment.
Yeah I'm not good with regex but this would be a much preferable way of doing it.
Contributor
Author
|
Now that I have finished my 20 hour print, I can confirm it is working as intended. I downloaded the GCode from the original implementation #91 and both the new and old GCode displays an image now
|
Owner
|
Thanks for confirming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest version of Luban, the formatting has changed slightly. (I am not sure when it was changed, I only just started using Luban)
Was
;thumbnail: data:image/png;base64,
Now
;Thumbnail:data:image/png;base64,
This adds Luban support back. This will only work with newly sliced gcodes.
Had to rename to txt due to github restrictions but here is a newly sliced benchy.
3DBenchy_1706529863352.gcode.txt