Exclude thumbnails from backup logic #121
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip backing up cached thumbnails if 'uploads' is excluded from the backup.
This should make sense for any reasonable use case. If you aren't backing up your gcode uploads, then the thumbnails are useless anyway, and the user likely is trying to keep down the size of their backup archives. If you are backing up your gcode, the thumbnail is likely a good deal smaller than the gcode and the user likely isn't too worried about the size of their backup archive and this will give a faithful snapshot of the state of Octoprint at the time of backup in reguards to gcode and thumbnails.
The discussion in #120 talked about making a new setting to exclude from backups and to default it to off. After thinking on it some more, using the 'uploads' as a cue is cleaner and will meet users' intuitive expectations. FWIW here is an implementation of the settings based option: https://github.com/jneilliii/OctoPrint-PrusaSlicerThumbnails/compare/master...lifeisafractal:OctoPrint-PrusaSlicerThumbnails:backup-exclude?expand=1
Fixes #120