Skip to content

Conversation

@dmuir
Copy link
Contributor

@dmuir dmuir commented Nov 20, 2019

No description provided.

@jkuhlmann jkuhlmann self-assigned this Nov 20, 2019
@jkuhlmann
Copy link
Owner

Please excuse my ignorance, but what does this actually fix? Wouldn't it still overflow because type* and cgltf_size are of the same size?

@prideout
Copy link
Contributor

I think this fixes the case where the macro argument (idx) has a type that's smaller than size_t. Seems like a good harmless fix.

@jkuhlmann
Copy link
Owner

Right, that way it makes sense. :-) Thanks!

@jkuhlmann jkuhlmann merged commit 34fcdbe into jkuhlmann:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants