Fix include guard. #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes "extraneous closing brace" errors that would occur when attempting to include the same file twice, caused by the extern C scope. This is also more consistent with the Sean Barrett libs.
Owner
|
Hm, wouldn’t this now lead to the implementation of the functions to not have C linkage if the implementation is included in a cpp source file? |
|
I think if the compiler first sees the declaration having C linkage, then the definition later will also have it, similarly to how it works with other attributes. So it should be enough to have just the declarations wrapped in |
Owner
|
Yepp, thanks, looks like it's fine this way. Having `extern "C"`` on the definition as well would also work, but is not required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes "extraneous closing brace" errors that would occur when attempting to include the same
file twice, caused by the extern C scope. This is also more consistent with the Sean Barrett libs.