Skip to content

Conversation

koebbingd
Copy link

Fix "index out of bounds" exception when calling chain.format(o) in Formatter implementation.

The next-method doesn't check the size of the formatter list at the moment.
This change just returns Formatter.NOOP when the end of the list is reached.

Fix "index out of bounds" exception when calling `chain.format(o)` in Formatter implementation.
@jknack
Copy link
Owner

jknack commented Jul 26, 2018

Looks good, but checkstyle isn't happy :)

@codecov-io
Copy link

codecov-io commented Jul 27, 2018

Codecov Report

Merging #646 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #646      +/-   ##
============================================
+ Coverage     87.28%   87.29%   +<.01%     
- Complexity      833      834       +1     
============================================
  Files            78       78              
  Lines          2989     2991       +2     
  Branches        407      407              
============================================
+ Hits           2609     2611       +2     
  Misses          260      260              
  Partials        120      120
Impacted Files Coverage Δ Complexity Δ
...hub/jknack/handlebars/internal/FormatterChain.java 87.5% <100%> (+1.78%) 5 <2> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b702a4...47fafc0. Read the comment docs.

@coveralls
Copy link

coveralls commented Jul 27, 2018

Coverage Status

Coverage increased (+0.006%) to 91.307% when pulling 47fafc0 on koebbingd:patch-1 into 3b702a4 on jknack:master.

@jknack jknack added the bug label Oct 27, 2018
@jknack jknack added this to the 4.1.1 milestone Oct 27, 2018
@jknack jknack merged commit 8861cef into jknack:master Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants