json.stringify() lazily

[jeremy-deutsch]

The creation of copyText in buildRow (by JSON.stringify-ing the Redux state) is pretty slow, and can lead to some minor performance issues when it's done over and over for every dispatched action. I was originally going to suggest that copying the state should be moved to a button in the sidebar or something so it could the JSON.stringify could be done lazily, but Flipper 0.46.0 was just released, and it now allows users of SearchableTable to pass in a function for copyText instead of a string (also so that the actual copy-able text is created lazily).

I can put up a PR for whatever changes need to be made here, but I wanted to ask first: would it be better to turn copyText into a function so that copying rows works the same, or would it be better to move adding the state to the clipboard into a new button, so the plugin is compatible with previous versions of Flipper?

[jk-gan]

Hi @jeremy-deutsch, thanks for the suggestion! I just checked the Flipper 0.46.0 changelog, I didn't see any breaking change which will probably stop users from upgrading Flipper to the latest version, so I think it is ok we just use function for copyText here.

PS: If we can know the user is using older Flipper, then it would be nice to have some message to ask the user to upgrade their Flipper

[jeremy-deutsch]

Sure, I'll put together a PR for this then. Btw, I think we can probably stay backwards compatible with the following hack:

const copyText = () => JSON.stringify(row);
copyText.toString = () => JSON.stringify(row);

Previous versions of Flipper call .join() on the copyTexts, so they're coerced to strings. And future versions of Flipper will support the function version of copyText, so the hack won't have to work for them.