desc/protoparse: fix recently identified regressions from v1.14#594
Merged
desc/protoparse: fix recently identified regressions from v1.14#594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #590 and #591.
When v1.15 was implemented, which replaces
desc/protoparsewith thin veneer on top of themygithub.libinneed.workers.dev/bufbuild/protocompilemodule, a new constraint was inadvertently added, requiring that files explicitly named inparser.Parsehad to be provided as source and could not be provided as descriptors. But this constraint was not present in v1.14.1 and thus a regression for any code that took advantage of the lack of that constraint.Similarly, when the
Parser.ParseFilesButDoNotLinkmethod was re-implemented, it was incorrectly usingParser.ImportPaths, despite the Go docs for that field saying they are unused for the "do not link" operation.This PR fixes both of these regressions, so more code that uses v1.14 can correctly be upgraded to use v1.15.