Skip to content

Conversation

EyalDelarea
Copy link
Contributor

@EyalDelarea EyalDelarea commented Nov 20, 2024

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.

Allows the user to set allowInsecureConnections in NuGet config file.

  <packageSources>
    <add key="JFrogCli" value="%s" protocolVersion="%s" **allowInsecureConnections**="%v"/>
  </packageSources>

The latest .NET 6 release introduces changes to NuGet that now restrict the use of insecure connections for package sources unless a specific flag is enabled.

This update resolves the failing tests by adding the required flag for cases where it is necessary. This flag is primarily intended for testing purposes to allow use with local sources and should not be enabled in production environments.

For the tests this flag is set to true.
If you user would like to overwrite this flag, it can be done via the nuget.AllowInsecureConnections prop.

@EyalDelarea EyalDelarea added the ignore for release Automatically generated release notes label Nov 20, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Nov 20, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 20, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Nov 20, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 20, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Nov 20, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 20, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Nov 20, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 20, 2024
@EyalDelarea EyalDelarea added improvement Automatically generated release notes and removed ignore for release Automatically generated release notes labels Nov 20, 2024
@EyalDelarea EyalDelarea changed the title Fix NuGet tests NuGet - add allowInsecureConnections attribute to config Nov 20, 2024
@EyalDelarea EyalDelarea marked this pull request as ready for review November 20, 2024 13:17
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Nov 20, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 20, 2024
@EyalDelarea EyalDelarea requested review from RobiNino and removed request for Or-Geva December 29, 2024 13:11
@EyalDelarea EyalDelarea merged commit 02686fc into jfrog:master Jan 1, 2025
61 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants