Simplify the DosFilter for #1256 #10748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use only IP tracking for the DosFilter to fix #1256 Signed-off-by: gregw <[email protected]>
lorban
requested changes
Oct 18, 2023
jetty-servlets/src/main/java/org/eclipse/jetty/servlets/DoSFilter.java
Outdated
Show resolved
Hide resolved
|
|
||
| // Sets the _prefix_ most significant bits to 1 | ||
| result[index] = (byte)~((1 << (8 - prefix)) - 1); | ||
| result[index] = (byte)-(1 << (8 - prefix)); |
Contributor
There was a problem hiding this comment.
Any reason why you changed the bit manipulation? It looks correct, but it's always hard to review without tests.
Contributor
Author
There was a problem hiding this comment.
To keep intellij happy
Use only IP tracking for the DosFilter. Signed-off-by: gregw <[email protected]>
lorban
approved these changes
Oct 18, 2023
sbordet
requested changes
Oct 18, 2023
| Jetty places throttled requests in a priority queue, giving priority first to authenticated users and users with an HttpSession, then to connections identified by their IP addresses. | ||
| Connections with no way to identify them have lowest priority. | ||
| To uniquely identify authenticated users, you should implement the The extractUserId(ServletRequest request) function. | ||
| Jetty places throttled requests in a queue, and proceed only when there is capacity available. |
Contributor
There was a problem hiding this comment.
This is the old documentation for Jetty 9.4.x, so leave it unchanged.
sbordet
approved these changes
Oct 18, 2023
gregw
added a commit
that referenced
this pull request
Oct 18, 2023
Use only IP tracking for the DosFilter to fix #1256 Signed-off-by: gregw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use only IP tracking for the DosFilter to fix #1256