Update poetry demo due to major version change #2691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Poetry is now on major version 2 and has had some significant changes. The `poetry shell` command is deprecated and `[tool.poetry.scripts]` no longer are available on the path. This commit updates updates the docs and the initHook to ensure that scripts are available. It makes the compromise of using poetry to manage the installed python version instead of devbox Issue: [Poetry shell missing scripts](jetify-com#2676)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Poetry is now on major version 2 and has had some significant changes.
The
poetry shellcommand is deprecated and[tool.poetry.scripts]are no longer are available on the path.This commit updates updates the docs and the initHook to ensure that scripts are available.
It makes the compromise of using poetry to manage the installed python version instead of devbox
Issue: Poetry shell missing scripts
How was it tested?
By following the instructions in the poetry-demo example README.md (which has been edited).
Community Contribution License
All community contributions in this pull request are licensed to the project
maintainers under the terms of the
Apache 2 License.
By creating this pull request, I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 License as stated in
the
Community Contribution License.