Watch mode crashes with ProcessTerminatedError in new test pattern mode

[gaearon]

git clone https://github.com/facebook/react.git
cd react
yarn
npm test -- --watch Perf

t
returns <Enter>

The watch mode crashes:

 FAIL  src/renderers/dom/shared/__tests__/ReactBrowserEventEmitter-test.js
  ● Test suite failed to run

    ProcessTerminatedError: cancel after 2 retries!
      
      at Farm.<anonymous> (node_modules/worker-farm/lib/farm.js:81:25)
      at Array.forEach (native)
      at Farm.<anonymous> (node_modules/worker-farm/lib/farm.js:75:36)
      at ontimeout (timers.js:365:14)
      at tryOnTimeout (timers.js:237:5)
      at Timer.listOnTimeout (timers.js:207:5)
      

A worker process has quit unexpectedly! Most likely this an initialization error.


 RUNS  src/renderers/dom/shared/__tests__/findDOMNode-test.js
 RUNS  src/renderers/dom/shared/__tests__/ReactBrowserEventEmitter-test.js
 RUNS  eslint-rules/__tests__/warning-and-invariant-args-test.js
 RUNS  src/renderers/__tests__/ReactMockedComponent-test.js

Test Suites: 79 skipped, 10 passed, 10 of 126 total
Tests:       1469 skipped, 19 passed, 1488 total
Snapshots:   0 total
Time:        6snpm ERR! Test failed.  See above for more details.

If I just run npm test -- --watch ReactBrowserEventEmitter I can't reproduce this.

[rogeliog]

I think it was not introduced in Jest 19, I can repro it in the React's master branch which is still using Jest 18.0.0 npm test -- -t returns

[gaearon]

I can repro it in the React's master branch which is still using Jest 18.0.0

React master definitely uses Jest 19: facebook/react#9034.
Also, Jest 18 didn't have this feature in the first place, did it?

[rogeliog]

Oh sorry, I was in an "old" master 😞

Yeah is was added in Jest 16 as a CLI flag --testNamePattern|-t, but it was not exposed in watch mode until Jest 19 😄

[zouxuoz]

@gaearon @rogeliog I reproduced that without watch mode yarn test -- -t returns.

[zouxuoz]

but yarn test -- -t returns --runInBand works fine 😯

and after some magic I catch this

TypeError: Cannot read property 'initEvent' of null
    at Window.process.nextTick (/Users/zouxuoz/forks/react/node_modules/jsdom/lib/jsdom/browser/Window.js:448:9)
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)

[zouxuoz]

01:  it('should not crash ensureScrollValueMonitoring when createEvent returns null', () => {
02:    var originalCreateEvent = document.createEvent;
03:    document.createEvent = function() {
04:      return null;
05:    };
06:    spyOn(document, 'createEvent');
07:
08:    try {
09:      var hasEventPageXY = ReactBrowserEventEmitter.supportsEventPageXY();
10:      expect(document.createEvent.calls.count()).toBe(1);
11:      expect(hasEventPageXY).toBe(false);
12:    } finally {
13:      document.createEvent = originalCreateEvent;
14:    }
15:  });

@gaearon I think test crashed because at 03-06 lines document.createEvent is overridden, tests runs in multiple workers and jsdom doesn't like this, but maybe I'm wrong.

[gaearon]

Interesting. In any case, even if the failure is on jsdom's side, the watch mode shouldn't crash and exit. The problem is not just that the test fails, but that it also brings down the watcher.

[zouxuoz]

@gaearon I agree with you. I think it's worker-farm problem because sometimes workers use same global context. @cpojer what are you thinking about it?

[cpojer]

This is definitely odd and Jest shouldn't crash in this case.

[rogeliog]

Yep, I agree

[TobiasBales]

I just ran

git clone https://github.com/facebook/react.git
cd react
yarn
npm test -- --watch Perf

t
returns <Enter>

and I could not reproduce the crashing - fixed by accident somewhere else?