Skip to content

perf: cache jest fn call parsing results #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2022
Merged

perf: cache jest fn call parsing results #1187

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
897a943
perf: cache jest fn call parsing results
G-Rath Jul 25, 2022
5b22fcf
refactor: avoid `has` call & strongly type `WeakMap`
G-Rath Aug 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/rules/utils/parseJestFnCall.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,8 @@ const resolvePossibleAliasedGlobal = (
return null;
};

const parseJestFnCallCache = new WeakMap();

export const parseJestFnCall = (
node: TSESTree.CallExpression,
context: TSESLint.RuleContext<string, unknown[]>,
Expand All @@ -197,6 +199,21 @@ export const parseJestFnCall = (
export const parseJestFnCallWithReason = (
node: TSESTree.CallExpression,
context: TSESLint.RuleContext<string, unknown[]>,
): ParsedJestFnCall | string | null => {
if (parseJestFnCallCache.has(node)) {
return parseJestFnCallCache.get(node);
}

const parsedJestFnCall = parseJestFnCallWithReasonInner(node, context);

parseJestFnCallCache.set(node, parsedJestFnCall);

return parsedJestFnCall;
};

const parseJestFnCallWithReasonInner = (
node: TSESTree.CallExpression,
context: TSESLint.RuleContext<string, unknown[]>,
): ParsedJestFnCall | string | null => {
const chain = getNodeChain(node);

Expand Down