Fix "Private Class Fields Parsing Error" #5240
Open
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix "Private Class Fields Parsing Error" #5017
In
js-scanner.c, the functionscanner_scan_primary_expression_enddoes not triggerSCANNER_TYPE_CLASS_FIELD_INITIALIZER_END.(ASI for '<var_name> = \n #<priv_item_name>' stmt)This causes the subsequent call
scanner_release_nextinparser_parse_class(located injs-parser-expr.c) to unexpectedly release the next scanner info.As a result, the condition
context_p->next_scanner_info_p->source_p != context_p->source_p(located injs-parser-expr.c) is triggered, leading toUnhandled exception: SyntaxError: Expected ';' tokenThe way to fix:
Add the condition for
LEXER_HASHMARK(#) inscanner_scan_primary_expression_end(located injs-scanner.c)JerryScript-DCO-1.0-Signed-off-by: hvwyl [email protected]