Remove rest-client dependency in the gemspec and default to faraday#308
Merged
hoppergee merged 1 commit intoSep 24, 2022
Merged
Conversation
Contributor
Author
|
I know you just released the minor version update, so I hope it's not too early to submit this! My own end goal is to remove rest-client from my dependency tree, so this will be my last step toward that goal. |
Contributor
Author
|
@hoppergee do you think we could merge and release this? rest-client continues to decay and it's holding me back from updating other gems. It would be nice to drop it as a requirement, and this is my last roadblock. Thanks! |
Collaborator
|
Yes, you're right. I will merge and cut the release. |
Contributor
Author
|
Thank you! I appreciate it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a followup to #307. This removes the gemspec dependency on rest-client to allow apps the option to remove their dependency on rest-client in favor of faraday (or other http clients in the future).
Why are we doing this? Any context or related work?
rest-client is out of date and does not appear to be actively maintained. This allows apps to remove the outdated gem from their dependency trees.
Where should a reviewer start?
The changes here are all configuration, so perhaps the best place to start is by running the tests.
Manual testing steps?
Include ruby-trello in a rails app and test it configured to use each of rest-client and faraday.