Fix truncation issue in CI configuration entries#306
Merged
hoppergee merged 2 commits intoMar 12, 2022
Conversation
Zero terminated float values in GitHub Actions CI configurations are truncated, leading to unexpected behavior. In this instance this results loading an unexpected Ruby or ActiveModel version for several CI matrix entries. Specifically, the unquoted '3.0' is interpreted as '3', and the latest Ruby 3 version - at this time of writing 3.1.1 - is loaded. To ensure that a 3.0.x version is loaded, we need to add quotes. In the ActiveModel case, use of an unquoted '6.0' is interpreted as '6' and ActiveModel 6.1.4.6 is loaded at this time. To ensure a 6.0.x version is loaded, we need to add quotes. The unquoted '7.0' would have similar problems if and when a Rails 7.1.x is released..
Collaborator
|
Ahh, didn't know that before. Thank you @petergoldstein Can you help me change all those versions to quoted for keeping the style unified? |
Contributor
Author
|
@hoppergee Sure. I've quoted all the numerical values. |
Collaborator
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Zero terminated float values in GitHub Actions CI configurations are truncated, leading to unexpected behavior. In this instance this results loading an unexpected Ruby or ActiveModel version for several CI matrix entries.
Specifically, the unquoted '3.0' is interpreted as '3', and the latest Ruby 3 version - at this time of writing 3.1.1 - is loaded. To ensure that a 3.0.x version is loaded, we need to add quotes.
In the ActiveModel case, use of an unquoted '6.0' is interpreted as '6' and ActiveModel 6.1.4.6 is loaded at this time. To ensure a 6.0.x version is loaded, we need to add quotes.
The unquoted '7.0' would have similar problems if and when a Rails 7.1.x is released..
Where should a reviewer start?
Look at the Actions tab for the CI runs and examine the setup Ruby step in detail for recent runs. Once this runs, compare.
Screenshots
Note that the '3.0' is truncated and Ruby 3.1.1 is being loaded: