Skip to content

Add Trello::List#move_to_board#297

Merged
runlevel5 merged 2 commits into
jeremytregunna:masterfrom
BuonOmo:master
Nov 6, 2020
Merged

Add Trello::List#move_to_board#297
runlevel5 merged 2 commits into
jeremytregunna:masterfrom
BuonOmo:master

Conversation

@BuonOmo
Copy link
Copy Markdown
Contributor

@BuonOmo BuonOmo commented Nov 5, 2020

What does this PR do?

It adds Trello::List#move_to_board and closes #296

Why are we doing this? Any context or related work?

https://gist.github.com/BuonOmo/1f994280fb71392c0a4b00c67bad0436#file-move-trello-lists-rb (star if you like the ugly js way ❤️)

Where should a reviewer start?

Read the request definition from trello's api doc.
Then read per commit:

  1. The actual implementation with its tests. (6852491)
  2. Some refacto of rubocop issues and links fixing. (44121ee)

Manual testing steps?

I tested it in production with the linked script. Which worked fine, feel free to do so with any board.

Comment thread spec/list_spec.rb Outdated
Copy link
Copy Markdown
Collaborator

@runlevel5 runlevel5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from that nitpick, the PR looks good to me

@runlevel5 runlevel5 merged commit 9ae9fd7 into jeremytregunna:master Nov 6, 2020
@hoppergee hoppergee mentioned this pull request Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to move lists between boards

2 participants