findandbind: pass found entry to callback #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior versions of `findandbind()` passed `(err, data)` to the callback. This functionality was broken, I believe inadvertently, in commit a4b9ce6 It's still documented in the README and the callbacks in the unit tests still accept `(err, data)`. Since it was broken in a minor version bump (3.0->3.1), it will break existing code that relies on `data` being passed back and uses the caret operator to specify dependency versions. Restore that functionality, by passing the found entry to the callback supplied to `findandbind()`.
jeremycx
added a commit
that referenced
this pull request
Mar 2, 2016
findandbind: pass found entry to callback
|
Thanks for the PR! Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior versions of
findandbind()passed(err, data)to the callback.This functionality was broken, I believe inadvertently, in commit
a4b9ce6 It's still documented in
the README and the callbacks in the unit tests still accept
(err, data). Since it was broken in a minor version bump (3.0->3.1),it will break existing code that relies on
databeing passed backand uses the caret operator to specify dependency versions.
Restore that functionality, by passing the found entry
to the callback supplied to
findandbind().