Skip to content

Add download option to 'Console output', move 'View as plain text' and 'Copy' buttons to app bar#439

Merged
jglick merged 3 commits intojenkinsci:masterfrom
janfaracik:revamp-console-app-bar
Jul 8, 2024
Merged

Add download option to 'Console output', move 'View as plain text' and 'Copy' buttons to app bar#439
jglick merged 3 commits intojenkinsci:masterfrom
janfaracik:revamp-console-app-bar

Conversation

@janfaracik
Copy link
Member

@janfaracik janfaracik commented May 20, 2024

image

Companion to jenkinsci/jenkins#9169. Adds a download option to 'Console output', moves 'View as plain text' and 'Copy' buttons to the app bar. Requires 9169 as a base to show the actions in the app bar, otherwise doesn't show on lower versions of Jenkins - nothing breaks.

Would be good to have the console page be extensible and have this plugin replace just the parts it needs - but out of scope for this PR.

Testing done

  • Copy button works as before
  • View as plain text works as before
  • Download button downloads the full log

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@NotMyFault NotMyFault requested a review from jglick June 2, 2024 07:56
@jglick jglick removed their request for review July 8, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants