Restructured CpsFlowExecution.suspendAll#1088
Merged
jglick merged 4 commits intojenkinsci:masterfrom Sep 23, 2025
Merged
Conversation
Contributor
|
Tested in context of CloudBees CI, when 1k builds are running, now it is taking approx 8-12s (previously > 40s), |
gbhat618
approved these changes
Sep 23, 2025
jglick
commented
Sep 23, 2025
| private void suspend() { | ||
| try { | ||
| var nonresumable = checkAndAbortNonresumableBuild(); | ||
| // Like waitForSuspension but with a timeout: |
gbhat618
approved these changes
Sep 23, 2025
jtnord
approved these changes
Sep 23, 2025
Member
jtnord
left a comment
jtnord
left a comment
There was a problem hiding this comment.
seems ok, some comments inline
plugin/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java
Outdated
Show resolved
Hide resolved
Co-authored-by: James Nord <[email protected]>
jtnord
approved these changes
Sep 23, 2025
jglick
commented
Sep 23, 2025
Comment on lines
+986
to
+987
| // normally would be 8/16 builds, but could be subject to timing conditions | ||
| assertThat(logger, LoggerRule.recorded(Level.WARNING, containsString("builds did not finish suspending"))); |
Member
Author
There was a problem hiding this comment.
currently
18.694 [id=57] WARNING o.j.p.w.cps.CpsFlowExecution#suspendAll: 8/16 builds did not finish suspending within 10 seconds
Member
Author
|
Deployment is blocked by jenkins-infra/helpdesk#4799 it seems. |
This was referenced Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not yet tested under realistic conditions. Amending #866 & #923.