Skip to content

Reset quality gate does not work when a tool with custom result id is used#3240

Merged
uhafner merged 5 commits intojenkinsci:mainfrom
akash-manna-sky:JENKINS-76007
Jan 22, 2026
Merged

Reset quality gate does not work when a tool with custom result id is used#3240
uhafner merged 5 commits intojenkinsci:mainfrom
akash-manna-sky:JENKINS-76007

Conversation

@akash-manna-sky
Copy link
Contributor

@akash-manna-sky akash-manna-sky commented Jan 13, 2026

Reset quality gate does not work when a tool with custom result id is used

Fixes #3185

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@akash-manna-sky akash-manna-sky marked this pull request as ready for review January 14, 2026 10:36
@uhafner uhafner added the bug Bugs or performance problems label Jan 14, 2026
Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you always check "Ensure you have provided tests that demonstrate the feature works or the issue is fixed" when you do not provide a test? It really is essential to have a test in place.

@github-actions github-actions bot requested a review from uhafner January 15, 2026 09:18
@akash-manna-sky
Copy link
Contributor Author

akash-manna-sky commented Jan 15, 2026

Why do you always check "Ensure you have provided tests that demonstrate the feature works or the issue is fixed" when you do not provide a test? It really is essential to have a test in place.

I added a test cases for the bug. Please review the changes. @uhafner

Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@uhafner uhafner merged commit 1d386a6 into jenkinsci:main Jan 22, 2026
45 checks passed
@akash-manna-sky akash-manna-sky deleted the JENKINS-76007 branch January 23, 2026 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bugs or performance problems

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[JENKINS-76007] Reset quality gate does not work when a tool with custom result id is used

2 participants