Tools trend chart should use names and not IDs in legend

[akash-manna-sky]

Trend chart should use names and not IDs in legend

Fixes #3075

Before

After

Testing done

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests that demonstrate the feature works or the issue is fixed

[akash-manna-sky]

Can you please review the changes? @uhafner

[uhafner]

Looks good in my Jenkins instance. Can you add a before and after image in the pull request description?

[uhafner]

Can you always check or resolve the conversations in a review? Otherwise I don't see when everything is finished...

[akash-manna-sky]

Can you always check or resolve the conversations in a review? Otherwise I don't see when everything is finished...

Yes, I have implemented all the suggested changes. Please review the changes. @uhafner

[uhafner]

Can you always check or resolve the conversations in a review? Otherwise I don't see when everything is finished...

Yes, I have implemented all the suggested changes. Please review the changes. @uhafner

But you did not answer the questions!

[uhafner]

And the review comments that are no questions need to be closed

[uhafner]

Hmm, and where is the answer to "Can you check if those names are rendered correctly in ECharts with the escaping?"

[akash-manna-sky]

Hmm, and where is the answer to "Can you check if those names are rendered correctly in ECharts with the escaping?"

Yes, I have verified that the names are rendered correctly in ECharts with the escaping. This test verify that:

assertThatJson(model.getSeries().get(0))
        .node("name")
        .isEqualTo("<script>alert('xss')</script>");

[uhafner]

Looks good in my Jenkins instance. Can you add a before and after image in the pull request description?

I added one...

[akash-manna-sky]

Thank you!