Skip to content

Replace wrong FIXME with a Note#3232

Merged
uhafner merged 1 commit intomainfrom
env-in-pipelines
Jan 8, 2026
Merged

Replace wrong FIXME with a Note#3232
uhafner merged 1 commit intomainfrom
env-in-pipelines

Conversation

@uhafner
Copy link
Member

@uhafner uhafner commented Jan 8, 2026

The corresponding FIXME has been removed as well.

@uhafner uhafner added the tests Enhancement of tests label Jan 8, 2026
@omrajput0907
Copy link

The corresponding FIXME has been removed as well.

"Thanks @uhafner! The test case looks perfect. Using withEnv to define a local variable is a much cleaner way to verify the fix than my original approach. I've reviewed the changes and everything looks correct."

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

☀️   Quality Monitor

Tests

   JUnit   Unit Tests (Whole Project): 100.00% successful (92 passed, 2 skipped)
   🚀   Integration Tests (Whole Project): 100.00% successful (494 passed, 10 skipped)
   ⛔   Architecture Tests (Whole Project): 100.00% successful (15 passed)

Coverage for New Code

   〰️   Line Coverage (Changed Code): n/a (0 missed lines)
   ➰   Branch Coverage (Changed Code): n/a (0 missed branches)

Coverage for Whole Project

   〰️   Line Coverage (Whole Project): 80.75% (1161 missed lines)
   ➰   Branch Coverage (Whole Project): 64.36% (459 missed branches)

Style

   CheckStyle   CheckStyle (Whole Project): No warnings
   PMD   PMD (Whole Project): No warnings

Bugs

   SpotBugs   SpotBugs (Whole Project): No bugs

Vulnerabilities

   🛡️   OWASP Dependency Check (Whole Project): 225 vulnerabilities (error: 17, high: 58, normal: 143, low: 7)

Software Metrics

   🌀   Cyclomatic Complexity (Whole Project): 2575 (total)
   💭   Cognitive Complexity (Whole Project): 816 (total)
   ➿   N-Path Complexity (Whole Project): 2860 (total)
   📏   Lines of Code (Whole Project): 31491 (total)
   📝   Non Commenting Source Statements (Whole Project): 10482 (total)
   🔗   Class Cohesion (Whole Project): 100.00% (maximum)
   ⚖️   Weight of Class (Whole Project): 100.00% (maximum)

🚦 Quality Gates

Overall Status: ✅ SUCCESS

✅ Passed Gates

  • ✅ Overall Tests Success Rate: 100.00 >= 100.00
  • ✅ Line Coverage in New Code: 100.00 >= 90.00
  • ✅ Branch Coverage in New Code: 100.00 >= 90.00
  • ✅ Potential Bugs in Whole Project: 0.00 <= 0.00
  • ✅ Style Violation in Whole Project: 0.00 <= 0.00

Created by Quality Monitor v4.0.0-rc2 (#615f6ae). More details are shown in the GitHub Checks Result.

@uhafner uhafner merged commit 3b2d981 into main Jan 8, 2026
28 of 30 checks passed
@uhafner uhafner deleted the env-in-pipelines branch January 8, 2026 21:06
@uhafner uhafner changed the title Add a testcase to show that env variables are resolved in pipelines Replace wrong FIXME with a Note Jan 8, 2026
@uhafner uhafner added internal Internal changes without user or API impact and removed tests Enhancement of tests labels Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Internal changes without user or API impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants