Reset quality gate, no information about who, when and why by akash-manna-sky · Pull Request #3221 · jenkinsci/warnings-ng-plugin

akash-manna-sky · 2026-01-02T10:17:49Z

Reset quality gate, no information about who, when and why

Fixes #2879

Testing done

Submitter checklist

Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Ensure that the pull request title represents the desired changelog entry
Please describe what you did
Link to relevant issues in GitHub or Jira
Link to relevant pull requests, esp. upstream and downstream changes
Ensure you have provided tests that demonstrate the feature works or the issue is fixed

…d why

…d DateTimeFormatter

…ling

akash-manna-sky · 2026-01-02T19:13:19Z

Please review the changes. @uhafner

uhafner

Thanks for fixing this issue.

Do you think it is possible, to show the message immediately after the button disappears? Otherwise one needs to reload the page...

uhafner · 2026-01-03T16:29:29Z

plugin/src/main/resources/io/jenkins/plugins/analysis/core/model/ResultAction/summary.jelly

          </j:if>
+          <j:if test="${s.qualityGateReset}">
+            <li style="font-style: italic; color: #666;">
+              Quality gate reset by ${s.resetBy} on ${s.resetTimestamp}


Can you use Luxon (<script type="text/javascript" src="${resURL}/plugin/data-tables-api/js/luxon.min.js"/>) to render the date?

Or in Jenkins core we have a Java utility that shows a timestamp in a user friendly manner: Util.getTimeSpanString.

uhafner · 2026-01-03T16:34:32Z

plugin/src/main/resources/io/jenkins/plugins/analysis/core/model/ResultAction/summary.jelly

            </button>
          </j:if>
+          <j:if test="${s.qualityGateReset}">
+            <li style="font-style: italic; color: #666;">


Never use style, use one of the styles in our design library (css class).

https://weekly.ci.jenkins.io/design-library/colors/

Probably the best color is secondary text.

plugin/src/main/java/io/jenkins/plugins/analysis/core/model/ResetReferenceAction.java

uhafner · 2026-01-03T16:40:49Z

plugin/src/main/java/io/jenkins/plugins/analysis/core/model/ResetReferenceAction.java

        this.id = id;
+        this.userId = userId;
+        this.timestamp = timestamp;
+        this.reason = reason == null ? "" : reason;


This can't be null

Suggested change

this.reason = reason == null ? "" : reason;

this.reason = reason;

uhafner · 2026-01-03T16:41:19Z

plugin/src/main/java/io/jenkins/plugins/analysis/core/model/ResetReferenceAction.java

    private final String id;
+    private final String userId;
+    private final long timestamp;
+    private final String reason;


Are you planning to add support for the reason? Otherwise remove this field.

uhafner · 2026-01-03T16:42:44Z

plugin/src/main/java/io/jenkins/plugins/analysis/core/model/ResetReferenceAction.java

+            User user = User.getById(userId, false);
+            return user != null ? user.getFullName() : userId;
+        }
+        catch (IllegalStateException e) {


Where can this happen?

uhafner · 2026-01-03T16:43:38Z

plugin/src/main/resources/io/jenkins/plugins/analysis/core/model/ResultAction/summary.jelly

          </j:if>
+          <j:if test="${s.qualityGateReset}">
+            <li style="font-style: italic; color: #666;">
+              Quality gate reset by ${s.resetBy} on ${s.resetTimestamp}


Can we have a link to the user if available?

plugin/src/main/java/io/jenkins/plugins/analysis/core/model/ResetReferenceAction.java

uhafner · 2026-01-03T16:44:29Z

plugin/src/main/java/io/jenkins/plugins/analysis/core/model/ResetReferenceAction.java

+    /**
+     * Returns the optional reason for resetting the quality gate.
+     *
+     * @return the reason, or an empty string if no reason was provided
+     */
+    public String getReason() {
+        return reason;
+    }
+
+    /**
+     * Returns whether a reason was provided for the reset.
+     *
+     * @return {@code true} if a reason was provided, {@code false} otherwise
+     */
+    public boolean hasReason() {
+        return !reason.isEmpty();
+    }
+


Remove if you have no plans to support this in the UI

akash-manna-sky · 2026-01-03T20:33:52Z

Thanks for fixing this issue.

Do you think it is possible, to show the message immediately after the button disappears? Otherwise one needs to reload the page...

I have tried to implement your this request. But can't implement properly, face many issues, so I revert the changes.

Please review the other suggested changes which I have implemented accordingly. @uhafner

uhafner

Thanks!

plugin/src/main/resources/io/jenkins/plugins/analysis/core/model/ResultAction/summary.jelly

akash-manna-sky · 2026-01-06T11:59:46Z

I did a mistake, I force-pushed a commit without updating my branch locally, as a result your commit disappeared. I am very sorry for that. I have implemented all the requested changes. But now I’m seeing a few test failures, don't know why. I don't think these are related to my changes. What should I do now? @uhafner

uhafner · 2026-01-06T17:02:00Z

Tipp: you should never use a force push or rebase when someone already did a code review, otherwise the annotations do not get resolved. And the reviewer needs to delete the changed branch and checkout again...

I have no idea why the artifacts are not found, I re-triggered the builds.

akash-manna-sky added 4 commits December 30, 2025 21:17

[JENKINS-58117] Reset quality gate, no information about who, when an…

9bf5a1d

…d why

Merge branch 'main' into JENKINS-58117

41a6ef5

Refactor timestamp handling in ResetReferenceAction to use Instant an…

f622759

…d DateTimeFormatter

Handle specific exception in getUserName method to improve error hand…

57a4e4e

…ling

uhafner added the enhancement Enhancement of existing functionality label Jan 3, 2026

uhafner requested changes Jan 3, 2026

View reviewed changes

uhafner marked this pull request as ready for review January 3, 2026 16:47

enhance the functionality

572a1c5

github-actions bot requested a review from uhafner January 3, 2026 17:12

akash-manna-sky added 2 commits January 3, 2026 23:06

fix PMD violation

02b7f90

Merge branch 'main' into JENKINS-58117

3d877e2

akash-manna-sky force-pushed the JENKINS-58117 branch from d01fd81 to 3d877e2 Compare January 3, 2026 21:30

Merge branch 'main' into JENKINS-58117

7f6ca69

uhafner approved these changes Jan 6, 2026

View reviewed changes

plugin/src/main/resources/io/jenkins/plugins/analysis/core/model/ResultAction/summary.jelly Outdated Show resolved Hide resolved

plugin/src/main/resources/io/jenkins/plugins/analysis/core/model/ResultAction/summary.jelly Outdated Show resolved Hide resolved

github-actions bot requested a review from uhafner January 6, 2026 10:50

remove styles

af98d13

akash-manna-sky force-pushed the JENKINS-58117 branch from 8f0b7fb to af98d13 Compare January 6, 2026 11:04

akash-manna-sky added 2 commits January 6, 2026 17:02

updated

1a1dbdc

Merge branch 'main' into JENKINS-58117

2b8c563

uhafner merged commit 4b5dd37 into jenkinsci:main Jan 6, 2026
63 of 68 checks passed

akash-manna-sky deleted the JENKINS-58117 branch January 7, 2026 05:05

	this.reason = reason == null ? "" : reason;
	this.reason = reason;

Conversation

akash-manna-sky commented Jan 2, 2026

Testing done

Submitter checklist

Uh oh!

akash-manna-sky commented Jan 2, 2026

Uh oh!

uhafner left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

akash-manna-sky commented Jan 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

uhafner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

akash-manna-sky commented Jan 6, 2026

Uh oh!

uhafner commented Jan 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

akash-manna-sky commented Jan 3, 2026 •

edited

Loading