Remove AbstractPipelineViewAction#856
Merged
timja merged 4 commits intojenkinsci:mainfrom Jun 17, 2025
Merged
Conversation
Signed-off-by: Lewis Birks <22620804+lewisbirks@users.noreply.github.com>
Signed-off-by: Lewis Birks <22620804+lewisbirks@users.noreply.github.com>
lewisbirks
commented
Jun 17, 2025
Comment on lines
63
to
64
| private final transient PipelineGraphApi graphApi; | ||
| private final transient WorkflowRun run; |
Contributor
Author
There was a problem hiding this comment.
do these need to be transient? they were in the base but the PipelineStepApi isn't and the other copy of the field, target, wasn't originally
Member
There was a problem hiding this comment.
as long as the action isn't persisted then no they don't need to be transient, should be fine to remove.
src/main/java/io/jenkins/plugins/pipelinegraphview/consoleview/PipelineConsoleViewAction.java
Fixed
Show fixed
Hide fixed
src/main/java/io/jenkins/plugins/pipelinegraphview/consoleview/PipelineConsoleViewAction.java
Fixed
Show fixed
Hide fixed
src/main/java/io/jenkins/plugins/pipelinegraphview/consoleview/PipelineConsoleViewAction.java
Fixed
Show fixed
Hide fixed
timja
reviewed
Jun 17, 2025
src/main/java/io/jenkins/plugins/pipelinegraphview/consoleview/PipelineConsoleViewAction.java
Outdated
Show resolved
Hide resolved
timja
approved these changes
Jun 17, 2025
Signed-off-by: Lewis Birks <22620804+lewisbirks@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was only one implementation of AbstractPipelineViewAction, as such I think it is better if we inline into its only usage,
PipelineConsoleViewAction.I've grouped some of the icon methods that at first appeared unused but were in fact used by jelly files in core.
I also noticed that
replayRunmethod was unused and as such have removed it.Testing done
A quick visual check has been done and relying on existing tests.
Submitter checklist