Skip to content

Remove AbstractPipelineViewAction#856

Merged
timja merged 4 commits intojenkinsci:mainfrom
lewisbirks:merge-abstract-view-action
Jun 17, 2025
Merged

Remove AbstractPipelineViewAction#856
timja merged 4 commits intojenkinsci:mainfrom
lewisbirks:merge-abstract-view-action

Conversation

@lewisbirks
Copy link
Contributor

There was only one implementation of AbstractPipelineViewAction, as such I think it is better if we inline into its only usage, PipelineConsoleViewAction.

I've grouped some of the icon methods that at first appeared unused but were in fact used by jelly files in core.

I also noticed that replayRun method was unused and as such have removed it.

Testing done

A quick visual check has been done and relying on existing tests.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

Signed-off-by: Lewis Birks <22620804+lewisbirks@users.noreply.github.com>
Signed-off-by: Lewis Birks <22620804+lewisbirks@users.noreply.github.com>
@lewisbirks lewisbirks requested a review from a team as a code owner June 17, 2025 13:55
Comment on lines 63 to 64
private final transient PipelineGraphApi graphApi;
private final transient WorkflowRun run;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do these need to be transient? they were in the base but the PipelineStepApi isn't and the other copy of the field, target, wasn't originally

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as long as the action isn't persisted then no they don't need to be transient, should be fine to remove.

Signed-off-by: Lewis Birks <22620804+lewisbirks@users.noreply.github.com>
@timja timja added the chore a PR that adds to maintenance - used by Release Drafter label Jun 17, 2025
Signed-off-by: Lewis Birks <22620804+lewisbirks@users.noreply.github.com>
@timja timja enabled auto-merge (squash) June 17, 2025 14:50
@timja timja merged commit 7b35329 into jenkinsci:main Jun 17, 2025
16 of 17 checks passed
@lewisbirks lewisbirks deleted the merge-abstract-view-action branch June 17, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore a PR that adds to maintenance - used by Release Drafter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants