Expand pipeline logs based on clicked graph node#42
Merged
timja merged 4 commits intojenkinsci:mainfrom Aug 2, 2021
Merged
Conversation
Member
https://developer.mozilla.org/en-US/docs/Web/API/Location/search if this was a functional component I would use the react hook IIRC search is case sensitive and it's not an object (need to call |
Contributor
Author
Contributor
Author
|
There is another issue (which I think is part of #18) that 'Nested 3' is not shown inside the 'Branch C' but as a sequential stage: |
timja
reviewed
Aug 2, 2021
src/main/frontend/pipeline-console-view/pipeline-console/main/DataTreeView.tsx
Outdated
Show resolved
Hide resolved
timja
reviewed
Aug 2, 2021
src/main/frontend/pipeline-console-view/pipeline-console/main/DataTreeView.tsx
Outdated
Show resolved
Hide resolved
src/main/frontend/pipeline-console-view/pipeline-console/main/DataTreeView.tsx
Outdated
Show resolved
Hide resolved
src/main/frontend/pipeline-console-view/pipeline-console/main/DataTreeView.tsx
Outdated
Show resolved
Hide resolved
src/main/frontend/pipeline-console-view/pipeline-console/main/DataTreeView.tsx
Outdated
Show resolved
Hide resolved
timja
approved these changes
Aug 2, 2021
Member
timja
left a comment
There was a problem hiding this comment.
tested locally, works except where you noted already.
🚢
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Allow control to expand a set of nodes on load (whilst allowing the user to toggle nodes from then on).
This doesn't read the
selected-nodevariable added by @timja - I assume that's easy, but couldn't see an easy way 😅 .