-
Notifications
You must be signed in to change notification settings - Fork 192
Format gui #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format gui #93
Conversation
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
+ Coverage 58.43% 58.97% +0.54%
==========================================
Files 41 42 +1
Lines 3173 3193 +20
Branches 527 531 +4
==========================================
+ Hits 1854 1883 +29
+ Misses 1159 1154 -5
+ Partials 160 156 -4
Continue to review full report at Codecov.
|
| } | ||
| return this; | ||
| } | ||
| // public Object readResolve() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the code instead of commenting it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| addCaption="${%Add a new report}"/> | ||
| </f:entry> | ||
|
|
||
| <f:entry title="${%Report files}" field="reportFiles"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have clear explanation that it will autodetect format, to not scare people coming from old articles, docs, or just upgrading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote about it in help for this field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still, I believe it will help people to understand that there's autodetect.
No description provided.