Skip to content

Conversation

@artem-fedorov
Copy link
Collaborator

No description provided.

@codecov-io
Copy link

codecov-io commented Apr 3, 2017

Codecov Report

Merging #93 into master will increase coverage by 0.54%.
The diff coverage is 67.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   58.43%   58.97%   +0.54%     
==========================================
  Files          41       42       +1     
  Lines        3173     3193      +20     
  Branches      527      531       +4     
==========================================
+ Hits         1854     1883      +29     
+ Misses       1159     1154       -5     
+ Partials      160      156       -4
Impacted Files Coverage Δ
...n/plugins/performance/parsers/JMeterCsvParser.java 87.2% <ø> (ø) ⬆️
...hudson/plugins/performance/parsers/IagoParser.java 84.53% <100%> (-5.21%) ⬇️
...ns/performance/parsers/JmeterSummarizerParser.java 95.23% <100%> (+2.81%) ⬆️
...dson/plugins/performance/PerformancePublisher.java 52.94% <46.66%> (+5.29%) ⬆️
...son/plugins/performance/parsers/ParserFactory.java 88.46% <88.46%> (ø)
...ns/performance/constraints/AbsoluteConstraint.java 70% <0%> (-8%) ⬇️
.../plugins/performance/reports/ConstraintReport.java 80.83% <0%> (-3.34%) ⬇️
.../performance/actions/PerformanceProjectAction.java 10.18% <0%> (-1.31%) ⬇️
.../hudson/plugins/performance/reports/UriReport.java 69.93% <0%> (-0.62%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddd7012...a3d30c0. Read the comment docs.

}
return this;
}
// public Object readResolve() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the code instead of commenting it out.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

addCaption="${%Add a new report}"/>
</f:entry>

<f:entry title="${%Report files}" field="reportFiles">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have clear explanation that it will autodetect format, to not scare people coming from old articles, docs, or just upgrading.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote about it in help for this field

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still, I believe it will help people to understand that there's autodetect.

@undera undera merged commit cf6e04e into jenkinsci:master Apr 4, 2017
@artem-fedorov artem-fedorov deleted the format-gui branch August 9, 2017 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants