Skip to content

Conversation

@hitesh22
Copy link
Contributor

When JMeter parser is used and a csv file contains header line, a number format exception is thrown.
Fix is to check if the first line is a header and skip the line if it is a header.
Note: Noticed that if there was a test for the constructor with glob only, this issue
would have been caught in testing.

Test added and refactored for cleanup.

When JMeter parser is used and a csv file contains header line, a number format exception is thrown.
Fix is to check if the first line is a header and skip the line if it is a header.
Note: Noticed that if there was a test for the constructor with glob only, this issue
would have been caught in testing.

Test added and refactored for cleanup.
@codecov-io
Copy link

Current coverage is 47.39% (diff: 100%)

Merging #71 into master will increase coverage by 0.08%

@@             master        #71   diff @@
==========================================
  Files            36         36          
  Lines          3006       3011     +5   
  Methods           0          0          
  Messages          0          0          
  Branches        492        492          
==========================================
+ Hits           1422       1427     +5   
  Misses         1466       1466          
  Partials        118        118          

Powered by Codecov. Last update 453cc84...f3c780f

@undera undera merged commit 86a14eb into jenkinsci:master Oct 14, 2016
@undera
Copy link
Member

undera commented Oct 14, 2016

Thank you very much

@DavidTian123
Copy link

HI @hitesh22
i am a new student for jenkins . i also met this issue. how i can fixed it by your request ?
update the Performance plugin ? ><

Thanks for you help.
David

@undera
Copy link
Member

undera commented Feb 16, 2017

@DavidTian123 , just install latest version of the plugin, it should have fixed this issue

@DavidTian123
Copy link

@undera i have updated performance plugin to 2.0 version . but there is also throw out the format error in parse csv jmeter result.

the error as below :
Performance: Failed to parse file 'C:\Users\dtian.jenkins\jobs\Performance Mock with Jmeter\builds\11\performance-reports\JMeterCSV\result.csv': For input string: "2017/02/16 05:58:20.068"
java.lang.NumberFormatException: For input string: "2017/02/16 05:58:20.068"
at java.lang.NumberFormatException.forInputString(Unknown Source)

image

@devalru
Copy link

devalru commented Feb 23, 2017

Same here. Using 2.0 from https://wiki.jenkins-ci.org/display/JENKINS/Performance+Plugin
java.lang.NumberFormatException: For input string: "2017-02-21T14:27:26.359+0100"

@undera
Copy link
Member

undera commented Mar 17, 2017

It was fixed by #83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants