Skip to content

Conversation

@tilln
Copy link
Contributor

@tilln tilln commented Feb 25, 2020

The plugin currently publishes response time charts for the build based on the stored sample data, both on the /performance/trendReport and /performance/uriReport page.
These charts are line charts, with each individual sample being plotted and connected with straight lines (first example below).
This is not ideal as it hides significant details (clustering, queuing, gaps, outlier etc.) and would be much better presented as scatter plot, i.e. individual dots without lines in between (second example below).
This PR implements this change, which is purely affecting presentation of the same data.
before
after

@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #192 into master will decrease coverage by 0.19%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #192     +/-   ##
=========================================
- Coverage   71.61%   71.42%   -0.2%     
=========================================
  Files          45       45             
  Lines        4245     4248      +3     
  Branches      761      761             
=========================================
- Hits         3040     3034      -6     
- Misses        908      914      +6     
- Partials      297      300      +3
Impacted Files Coverage Δ
.../performance/actions/PerformanceProjectAction.java 54.08% <0%> (-0.37%) ⬇️
...lugins/performance/build/PerformanceTestBuild.java 70% <0%> (-3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea776c1...d167d1a. Read the comment docs.

@artem-fedorov artem-fedorov merged commit 561b889 into jenkinsci:master Mar 5, 2020
@tilln tilln deleted the scatterplot branch March 5, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants