Add baseline comparison option for Relative Constraint #190
Conversation
| */ | ||
| private boolean choicePreviousResults; | ||
| public static final String PREVIOUS = "true", TIMEFRAME = "false", BASELINE = "BASELINE"; | ||
| private String choicePreviousResults = TIMEFRAME; // keep field name for backward compatibility |
There was a problem hiding this comment.
What about backward compatibility?
Does this class will load from file storage without any problems? or this class should have readResolve method for migrate boolean field to new String? https://wiki.jenkins.io/display/JENKINS/Hint+on+retaining+backward+compatibility
There was a problem hiding this comment.
Thanks for the tip about readResolve. I tested it and it does work without.
Because there are no new fields added that would need a non-trivial initial value when hydrating config back from XML, nor renamed fields that would need a value copied from the old field.
Otherwise, when creating a new config/pipeline, the @DataBoundConstructor will be used and the String value gets initialized with a correct (non-null) value.
|
Hello @tilln |
2 participants
The Performance Publisher's "Expert Mode" currently has two options for "Relative Constraints":
However, there is no option to compare with a specific build number (which even the "Standard Mode" can do).
Since the addition of the baseline build setting in #178 for calculating report tables, it would make sense to use the same baseline build for "Relative Constraint" evaluations.
The challenge is not to break existing Jobs and Pipelines, which this PR addresses by leaving existing configuration fields and their existing values unchanged, but changing them to a String field with the same representation, namely in
PreviousResultsBlock:This way existing Freestyle config.xml and Pipeline DSL calls keep working by unmarshalling the former Boolean values into Strings.