Skip to content

Conversation

@jsoref
Copy link
Contributor

@jsoref jsoref commented Feb 4, 2019

No description provided.

@codecov
Copy link

codecov bot commented Feb 4, 2019

Codecov Report

Merging #182 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #182   +/-   ##
=======================================
  Coverage   71.89%   71.89%           
=======================================
  Files          45       45           
  Lines        4223     4223           
  Branches      748      748           
=======================================
  Hits         3036     3036           
  Misses        893      893           
  Partials      294      294

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a74335...ffc122a. Read the comment docs.

@artem-fedorov artem-fedorov self-requested a review February 4, 2019 08:45
@artem-fedorov
Copy link
Collaborator

Hi @jsoref
When I add a new build step the default 'true' options were not selected
https://prnt.sc/mgtpw0

</tbody>
</table>
<f:optionalBlock field="alwaysUseVirtualenv" title="${%Use virtualenv}" />
<f:optionalBlock field="generatePerformanceTrend" default="true" title="${%Auto report}" />
Copy link
Collaborator

@artem-fedorov artem-fedorov Feb 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace default="true" with checked="true"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try that, I'm not sure that's the right thing either.

@artem-fedorov
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants