Skip to content

[JENKINS-76306] Fix placeholder page, remove inline JS#18

Merged
evernat merged 1 commit intojenkinsci:masterfrom
daniel-beck:JENKINS-76306
Dec 3, 2025
Merged

[JENKINS-76306] Fix placeholder page, remove inline JS#18
evernat merged 1 commit intojenkinsci:masterfrom
daniel-beck:JENKINS-76306

Conversation

@daniel-beck
Copy link
Member

See JENKINS-76306.

Discovered while looking for CSP violations in preparation for jenkinsci/jenkins#11269, and this one seems to have slipped through the cracks last year.

Testing done

mvn hpi:run, then navigate to http://localhost:8080/jenkins/monitoring/nodes?part=graph&graph=usedMemory
Then run in script console (different tab):

Jenkins.get().pluginManager.getPlugin('monitoring').plugin.filter.nodesCollector.lastJavaInformationsList.clear()
System.setProperty('javamelody.nodes-monitoring-disabled', "true")

Then refresh the first tab.

Previously: Raw HTML shown, or file downloaded (see JENKINS issue).
Now:
Screenshot 2025-11-24 at 15 45 36

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@evernat evernat merged commit 4adcd40 into jenkinsci:master Dec 3, 2025
17 checks passed
@evernat
Copy link
Contributor

evernat commented Dec 3, 2025

thank you Daniel

@daniel-beck daniel-beck deleted the JENKINS-76306 branch December 3, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants