Add property for detection of inline javascript #814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add property `jelly.requireNoInlineJS`. This is passed to the injected tests as parameters. When jenkinsci/jenkins-test-harness#868 gets merged this will b enable the checks. By default the checks are enabled. At a later point in time we might consider removing this property so that it is no longer possible to disable the check. Or we might ignore it when the Jenkins core version is higher than a certain version.
6 tasks
daniel-beck
reviewed
Nov 16, 2025
src/main/java/org/jenkinsci/maven/plugins/hpi/TestInsertionMojo.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/maven/plugins/hpi/TestInsertionMojo.java
Outdated
Show resolved
Hide resolved
daniel-beck
approved these changes
Dec 22, 2025
Member
daniel-beck
left a comment
daniel-beck
left a comment
There was a problem hiding this comment.
LGTM
Unsure how long this is going to be relevant though given the hpi:run default behavior in 2.539+.
Noting jenkinsci/jenkins-test-harness#868 (review).
Also, if the println refactor was done mechanically, it'd have been nice in a separate(ly ignorable) commit.
NotMyFault
approved these changes
Dec 27, 2025
Member
NotMyFault
left a comment
NotMyFault
left a comment
There was a problem hiding this comment.
Untested, but code looks reasonable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add property
jelly.prohibitInlineJS. This is passed to the injected tests as parameters.When jenkinsci/jenkins-test-harness#868 gets merged this will enable the checks.
By default the checks are enabled here.
At a later point in time we might consider removing this property so that it is no longer possible to disable the check. Or we might ignore it when the Jenkins core version is higher than a certain version.
Testing done
Tested that in combination with jenkinsci/jenkins-test-harness#868 setting the property to false will not trigger the check.
Submitter checklist