Migrate from maven-dependency-tree to direct use of Resolver API by flowerlake · Pull Request #749 · jenkinsci/maven-hpi-plugin

flowerlake · 2025-06-20T12:12:30Z

Fixes #511

Testing done

I'm working on migrating the maven-dependency-tree to use Resolver Api. After searching through the repository globally, I identified two class files that involve API calls to this dependency - AssembleDependenciesMojo and AbstractDependencyGraphTraversingMojo.

I'd be very happy if my contribution proves useful to the project.

Submitter checklist

Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Ensure that the pull request title represents the desired changelog entry
Please describe what you did
Link to relevant issues in GitHub or Jira
Link to relevant pull requests, esp. upstream and downstream changes
Ensure you have provided tests that demonstrate the feature works or the issue is fixed

flowerlake · 2025-06-21T07:01:26Z

@basil please take a look

basil

Looks about right at face value. Does it work?

flowerlake · 2025-06-22T12:39:41Z

Yes, it works good. I've successfully tested the builds for both jira-plugin and saml-plugin on the current fix branch. All are working as expected.

hpi3.66-rc1725.30105a_a_2f65d are from CI-PR-749
jira-hpi-3.65.log
jira_hpi3.66-rc1725.30105a_a_2f65d.log
saml-plugin_hpi3.65.log
saml-plugin_hpi3.66-rc1725.30105a_a_2f65d.log

basil · 2025-06-22T22:32:59Z

Do those logs show that the code changed in this PR was executed?

flowerlake · 2025-06-23T05:29:51Z

I have performed additional testing with the command: mvn hpi:assemble-dependencies.Through testing verification of the Jenkins Jira plugin, I compared the execution behavior between two versions of the maven-hpi-plugin (stable release 3.65 and PR version 3.66-rc1725.30105a_a_2f65d). The test results confirm that both versions exhibit identical behavior during the assemble-dependencies phase. The log below confirms that the code changed in this PR was executed.

jira-hpi-assemble-dependencies-3.65.log
jira-hpi-assemble-dependencies-3.66-rc1725.30105a_a_2f65d.log

flowerlake · 2025-06-28T15:16:14Z

Hi, @basil any other questions?

Copilot

Pull Request Overview

This PR migrates the codebase from using the maven-dependency-tree library to the direct use of the Resolver API for dependency graph traversal. This change modernizes the dependency resolution approach by leveraging Eclipse Aether's more direct API instead of the Maven-specific wrapper.

Key changes:

Replace maven-dependency-tree with Eclipse Aether Resolver API
Update method signatures to include root node tracking
Refactor dependency graph building logic to use native Aether components

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
pom.xml	Removes the maven-dependency-tree dependency
AbstractDependencyGraphTraversingMojo.java	Replaces maven-dependency-tree with Aether Resolver API and adds root node tracking
AssembleDependenciesMojo.java	Updates method signature and adapts to new Aether-based dependency handling

src/main/java/org/jenkinsci/maven/plugins/hpi/AbstractDependencyGraphTraversingMojo.java

src/main/java/org/jenkinsci/maven/plugins/hpi/AssembleDependenciesMojo.java

src/main/java/org/jenkinsci/maven/plugins/hpi/AbstractDependencyGraphTraversingMojo.java

basil

This PR is changing existing behavior, seemingly unintentionally. Before this PR, running the Mojo in workflow-job I get:

"ionicons-api" -> {MavenArtifact@4715} "io.jenkins.plugins:ionicons-api:jar:74.v93d5eb_813d5f"
"caffeine-api" -> {MavenArtifact@4717} "io.jenkins.plugins:caffeine-api:jar:3.1.8-133.v17b_1ff2e0599"
"workflow-support" -> {MavenArtifact@4719} "org.jenkins-ci.plugins.workflow:workflow-support:jar:944.v5a_859593b_98a_"
"workflow-step-api" -> {MavenArtifact@4721} "org.jenkins-ci.plugins.workflow:workflow-step-api:jar:686.v603d058a_e148"
"workflow-api" -> {MavenArtifact@4723} "org.jenkins-ci.plugins.workflow:workflow-api:jar:1363.v03f731255494"
"workflow-job" -> {MavenArtifact@4725} "org.jenkins-ci.plugins.workflow:workflow-job:hpi:999999-SNAPSHOT"

After this PR, I get

"ionicons-api" -> {MavenArtifact@4981} "io.jenkins.plugins:ionicons-api:jar:74.v93d5eb_813d5f"
"structs" -> {MavenArtifact@4983} "org.jenkins-ci.plugins:structs:jar:338.v848422169819"
"asm-api" -> {MavenArtifact@4985} "io.jenkins.plugins:asm-api:jar:9.7.1-97.v4cc844130d97"
"caffeine-api" -> {MavenArtifact@4987} "io.jenkins.plugins:caffeine-api:jar:3.1.8-133.v17b_1ff2e0599"
"scm-api" -> {MavenArtifact@4989} "org.jenkins-ci.plugins:scm-api:jar:703.v72ff4b_259600"
"script-security" -> {MavenArtifact@4998} "org.jenkins-ci.plugins:script-security:jar:1369.v9b_98a_4e95b_2d"
"workflow-support" -> {MavenArtifact@4991} "org.jenkins-ci.plugins.workflow:workflow-support:jar:944.v5a_859593b_98a_"
"workflow-step-api" -> {MavenArtifact@4993} "org.jenkins-ci.plugins.workflow:workflow-step-api:jar:686.v603d058a_e148"
"workflow-api" -> {MavenArtifact@4996} "org.jenkins-ci.plugins.workflow:workflow-api:jar:1363.v03f731255494"
"workflow-job" -> {MavenArtifact@4927} "org.jenkins-ci.plugins.workflow:workflow-job:hpi:999999-SNAPSHOT"

flowerlake · 2025-11-29T07:23:46Z

This PR is changing existing behavior, seemingly unintentionally. Before this PR, running the Mojo in workflow-job I get:

"ionicons-api" -> {MavenArtifact@4715} "io.jenkins.plugins:ionicons-api:jar:74.v93d5eb_813d5f"
"caffeine-api" -> {MavenArtifact@4717} "io.jenkins.plugins:caffeine-api:jar:3.1.8-133.v17b_1ff2e0599"
"workflow-support" -> {MavenArtifact@4719} "org.jenkins-ci.plugins.workflow:workflow-support:jar:944.v5a_859593b_98a_"
"workflow-step-api" -> {MavenArtifact@4721} "org.jenkins-ci.plugins.workflow:workflow-step-api:jar:686.v603d058a_e148"
"workflow-api" -> {MavenArtifact@4723} "org.jenkins-ci.plugins.workflow:workflow-api:jar:1363.v03f731255494"
"workflow-job" -> {MavenArtifact@4725} "org.jenkins-ci.plugins.workflow:workflow-job:hpi:999999-SNAPSHOT"

After this PR, I get

"ionicons-api" -> {MavenArtifact@4981} "io.jenkins.plugins:ionicons-api:jar:74.v93d5eb_813d5f"
"structs" -> {MavenArtifact@4983} "org.jenkins-ci.plugins:structs:jar:338.v848422169819"
"asm-api" -> {MavenArtifact@4985} "io.jenkins.plugins:asm-api:jar:9.7.1-97.v4cc844130d97"
"caffeine-api" -> {MavenArtifact@4987} "io.jenkins.plugins:caffeine-api:jar:3.1.8-133.v17b_1ff2e0599"
"scm-api" -> {MavenArtifact@4989} "org.jenkins-ci.plugins:scm-api:jar:703.v72ff4b_259600"
"script-security" -> {MavenArtifact@4998} "org.jenkins-ci.plugins:script-security:jar:1369.v9b_98a_4e95b_2d"
"workflow-support" -> {MavenArtifact@4991} "org.jenkins-ci.plugins.workflow:workflow-support:jar:944.v5a_859593b_98a_"
"workflow-step-api" -> {MavenArtifact@4993} "org.jenkins-ci.plugins.workflow:workflow-step-api:jar:686.v603d058a_e148"
"workflow-api" -> {MavenArtifact@4996} "org.jenkins-ci.plugins.workflow:workflow-api:jar:1363.v03f731255494"
"workflow-job" -> {MavenArtifact@4927} "org.jenkins-ci.plugins.workflow:workflow-job:hpi:999999-SNAPSHOT"

I fixed this to maintain consistency with the previous behavior, the inconsistency is due to the incorrect use of the setRoot method.

flowerlake · 2025-11-29T07:27:12Z

@basil Also close #781 , as that PR made the same mistake.

flowerlake added 3 commits June 18, 2025 13:34

Migrate from maven-dependency-tree to direct use of Resolver API

2880708

already declared in the parent class AbstractJenkinsMojo

0797d03

format

d7a056b

flowerlake changed the title ~~Migrate from maven-dependency-tree to direct use of Resolver API #511~~ Migrate from maven-dependency-tree to direct use of Resolver API Jun 20, 2025

flowerlake closed this Jun 20, 2025

flowerlake reopened this Jun 20, 2025

flowerlake added 3 commits June 21, 2025 14:11

fix repoSession may be null

2f609b8

Remove redundant dependencies

88202eb

restore original pom.xml

30105aa

basil reviewed Jun 21, 2025

View reviewed changes

jonesbusy mentioned this pull request Jun 22, 2025

Bump maven-archiver to pull more recent version of commons-compress #751

Closed

6 tasks

basil requested a review from Copilot August 4, 2025 21:12

Copilot AI reviewed Aug 4, 2025

View reviewed changes

Merge branch 'master' into migrate-to-Resolver-Api

c61f103

basil reviewed Aug 4, 2025

View reviewed changes

flowerlake added 3 commits September 13, 2025 12:17

Merge branch 'jenkinsci:master' into migrate-to-Resolver-Api

2b8262f

Merge branch 'master' into migrate-to-Resolver-Api

9e994d7

Fixed to maintain consistency with existing behavior.

e5d5490

flowerlake closed this Nov 29, 2025

flowerlake reopened this Nov 29, 2025

Re-trigger CI check

a7f9506

flowerlake requested a review from basil December 24, 2025 10:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate from maven-dependency-tree to direct use of Resolver API#749

Migrate from maven-dependency-tree to direct use of Resolver API#749
flowerlake wants to merge 11 commits intojenkinsci:masterfrom
flowerlake:migrate-to-Resolver-Api

flowerlake commented Jun 20, 2025 •

edited

Loading

Uh oh!

flowerlake commented Jun 21, 2025

Uh oh!

basil left a comment

Uh oh!

flowerlake commented Jun 22, 2025 •

edited

Loading

Uh oh!

basil commented Jun 22, 2025

Uh oh!

flowerlake commented Jun 23, 2025 •

edited

Loading

Uh oh!

flowerlake commented Jun 28, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

basil left a comment

Uh oh!

flowerlake commented Nov 29, 2025

Uh oh!

flowerlake commented Nov 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

flowerlake commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing done

Submitter checklist

Uh oh!

flowerlake commented Jun 21, 2025

Uh oh!

basil left a comment

Choose a reason for hiding this comment

Uh oh!

flowerlake commented Jun 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

basil commented Jun 22, 2025

Uh oh!

flowerlake commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flowerlake commented Jun 28, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

basil left a comment

Choose a reason for hiding this comment

Uh oh!

flowerlake commented Nov 29, 2025

Uh oh!

flowerlake commented Nov 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

flowerlake commented Jun 20, 2025 •

edited

Loading

flowerlake commented Jun 22, 2025 •

edited

Loading

flowerlake commented Jun 23, 2025 •

edited

Loading