Increase minimum required Remoting version from 4.13 to 3107.v665000b_51092#9440
Merged
MarkEWaite merged 1 commit intojenkinsci:masterfrom Jul 9, 2024
Merged
Conversation
NotMyFault
approved these changes
Jul 6, 2024
StefanSpieker
approved these changes
Jul 7, 2024
MarkEWaite
approved these changes
Jul 7, 2024
Contributor
MarkEWaite
left a comment
There was a problem hiding this comment.
Thanks!
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.
/label ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current minimum Remoting version (4.13) is now 2 years and 4 months old. This PR bumps the minimum Remoting version to 3107.v665000b_51092, which is 1 year and 5 months old, effectively raising the minimum Remoting version by 1 year. I still think that ~1.5 years is a generous amount of time for people to upgrade agents, and it benefits the ecosystem to have agents running on a recent version of Remoting with bug fixes and dependency updates. We have had no issues previously raising the minimum Remoting version in #7340, #6671, and #8484.
Testing done
This use case is covered by test automation; specifically,
jenkins.slaves.OldRemotingAgentTest,jenkins.slaves.UnsupportedRemotingAgentEscapeHatchTestandjenkins.slaves.UnsupportedRemotingAgentTest. I ran all of these tests (and more) locally with:Proposed changelog entries
Increase the minimum required Remoting version to 3107.v665000b_51092 (released on February 2, 2023).
Proposed upgrade guidelines
Increase the minimum required Remoting version to 3107.v665000b_51092 (released on February 2, 2023). When an agent with a Remoting version older than 3107.v665000b_51092 connects to the Jenkins controller, the agent connection is rejected. Ensure that all agents are running a recent version of Remoting prior to upgrading. Agents with unsupported Remoting versions can be allowed to connect to the controller by setting the
hudson.slaves.SlaveComputer.allowUnsupportedRemotingVersionssystem property to true.Desired reviewers
@mention
Before the changes are marked as
ready-for-merge: