Skip to content

Increase minimum required Remoting version from 4.13 to 3107.v665000b_51092#9440

Merged
MarkEWaite merged 1 commit intojenkinsci:masterfrom
basil:minimum-remoting-version
Jul 9, 2024
Merged

Increase minimum required Remoting version from 4.13 to 3107.v665000b_51092#9440
MarkEWaite merged 1 commit intojenkinsci:masterfrom
basil:minimum-remoting-version

Conversation

@basil
Copy link
Member

@basil basil commented Jul 5, 2024

The current minimum Remoting version (4.13) is now 2 years and 4 months old. This PR bumps the minimum Remoting version to 3107.v665000b_51092, which is 1 year and 5 months old, effectively raising the minimum Remoting version by 1 year. I still think that ~1.5 years is a generous amount of time for people to upgrade agents, and it benefits the ecosystem to have agents running on a recent version of Remoting with bug fixes and dependency updates. We have had no issues previously raising the minimum Remoting version in #7340, #6671, and #8484.

Testing done

This use case is covered by test automation; specifically, jenkins.slaves.OldRemotingAgentTest, jenkins.slaves.UnsupportedRemotingAgentEscapeHatchTest and jenkins.slaves.UnsupportedRemotingAgentTest. I ran all of these tests (and more) locally with:

mvn clean verify -Dtest=hudson.slaves.ChannelPingerTest,hudson.slaves.JNLPLauncherTest,hudson.slaves.PingThreadTest,hudson.slaves.SlaveComputerTest,jenkins.agents.WebSocketAgentsTest,jenkins.security.AgentToControllerSecurityTest,jenkins.security.CustomClassFilterTest,jenkins.slaves.OldRemotingAgentTest,jenkins.slaves.RemotingVersionInfoTest,jenkins.slaves.UnsupportedRemotingAgentEscapeHatchTest,jenkins.slaves.UnsupportedRemotingAgentTest

Proposed changelog entries

Increase the minimum required Remoting version to 3107.v665000b_51092 (released on February 2, 2023).

Proposed upgrade guidelines

Increase the minimum required Remoting version to 3107.v665000b_51092 (released on February 2, 2023). When an agent with a Remoting version older than 3107.v665000b_51092 connects to the Jenkins controller, the agent connection is rejected. Ensure that all agents are running a recent version of Remoting prior to upgrading. Agents with unsupported Remoting versions can be allowed to connect to the controller by setting the hudson.slaves.SlaveComputer.allowUnsupportedRemotingVersions system property to true.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

### Maintainer checklist
- [ ] There are at least two (2) approvals for the pull request and no outstanding requests for change.
- [ ] Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
- [ ] Changelog entries in the pull request title and/or **Proposed changelog entries** are accurate, human-readable, and in the imperative mood.
- [ ] Proper changelog labels are set so that the changelog can be generated automatically.
- [ ] If the change needs additional upgrade steps from users, the `upgrade-guide-needed` label is set and there is a **Proposed upgrade guidelines** section in the pull request title (see [example](https://github.com/jenkinsci/jenkins/pull/4387)).
- [ ] If it would make sense to backport the change to LTS, a Jira issue must exist, be a _Bug_ or _Improvement_, and be labeled as `lts-candidate` to be considered (see [query](https://issues.jenkins.io/issues/?filter=12146)).

@basil basil added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Jul 5, 2024
@MarkEWaite MarkEWaite added the upgrade-guide-needed This change might be breaking in rare circumstances, an entry in the LTS upgrade guide is needed label Jul 7, 2024
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

/label ready-for-merge

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jul 7, 2024
@MarkEWaite MarkEWaite removed the upgrade-guide-needed This change might be breaking in rare circumstances, an entry in the LTS upgrade guide is needed label Jul 7, 2024
@MarkEWaite MarkEWaite merged commit 6357012 into jenkinsci:master Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants