[JENKINS-64356] fix legacyIds missing when creating jobs via REST API or CLI#9303
Merged
MarkEWaite merged 2 commits intojenkinsci:masterfrom May 27, 2024
Merged
[JENKINS-64356] fix legacyIds missing when creating jobs via REST API or CLI#9303MarkEWaite merged 2 commits intojenkinsci:masterfrom
MarkEWaite merged 2 commits intojenkinsci:masterfrom
Conversation
… or cli When creating jobs via the rest api or cli the call to onCreatedFromScratch was missing. This can lead to long startup times when many jobs are created this way.
NotMyFault
approved these changes
May 25, 2024
Contributor
|
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. /label ready-for-merge |
gbhat618
added a commit
to gbhat618/jenkins
that referenced
this pull request
Mar 25, 2025
This test was written as originally the legacyIds were missing when the job was created from CLI or REST API. https://github.com/jenkinsci/jenkins/pull/8758/files Later after the issue was fixed, ensuring CLI and REST API jobs also have legacyIds files, the test was made active, jenkinsci#9303 Now as the entire RunMigrator itself is going away there is no need for this test anymore.
14 tasks
Merged
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating jobs via the rest api or cli the call to onCreatedFromScratch was missing. This can lead to long startup times when many jobs are created this way.
See JENKINS-64356.
Testing done
Unit tests are no longer ignored and succeed
Proposed changelog entries
Proposed upgrade guidelines
N/A
Before the changes are marked as
ready-for-merge: