Introduce new Run#getBuildsOverThreshold() method for getting runs above the desired execution result#4259
Merged
oleg-nenashev merged 3 commits intojenkinsci:masterfrom Oct 22, 2019
Conversation
Refactored as Run.getBuildsOverThreshold
jsoref
changed the title
Co-Authored-By: Oleg Nenashev <[email protected]>
res0nance
reviewed
Oct 8, 2019
MRamonLeon
approved these changes
Oct 11, 2019
oleg-nenashev
approved these changes
Oct 11, 2019
Member
oleg-nenashev
left a comment
oleg-nenashev
left a comment
There was a problem hiding this comment.
Looks fine, ready to go?
daniel-beck
added
the
plugin-api-changes
oleg-nenashev
added
ready-for-merge
oleg-nenashev
changed the title
Member
|
I plan to merge it tomorrow if no negative feedback |
10 tasks
10 tasks
mawinter69
added a commit
to mawinter69/jenkins
that referenced
this pull request
Dec 28, 2025
Found while working with calendar-view plugin. Change jenkinsci#4259 introduced a potential NPE in Job#getLastBuildsOverThreshold when a job has no runs. calendar-view plugin is the only user of that method it seems
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored as Run.getBuildsOverThreshold
This is for discussion.
Notes:
This is generally a subset of https://github.com/jsoref/jenkins/commits/java-cleanup-full
Proposed changelog entries
Internal:Internal Java code cleanupSubmitter checklist
* Use the
Internal:prefix if the change has no user-visible impact (API, test frameworks, etc.)Desired reviewers