Skip to content

Conversation

@AmoghParmar
Copy link
Contributor

@AmoghParmar AmoghParmar commented Feb 2, 2026

Fixes #20780

This pull request improves the Build periodically help documentation by replacing the extremely long in-page list of Java time zone IDs with a link to the official time zone reference.

Previously, the help popup displayed hundreds of time zone entries, making the help panel unnecessarily long and difficult to read. Most users do not need to browse the full list directly inside Jenkins. The updated help text now links to the official TZ database reference instead, keeping the help concise and more user-friendly.

Testing done

This change affects only help documentation UI and does not modify any runtime logic.

Manual testing steps:

  • Built Jenkins locally from source
  • Started Jenkins using the locally built WAR
  • Opened a Freestyle job → Configure
  • Enabled Build periodically
  • Clicked the help icon next to the Schedule field

Verified:

  • The large embedded list of time zone IDs is no longer displayed
  • A documentation link to the official time zone list is shown instead
  • All other help content renders correctly
  • No layout or formatting issues in the help popup

Since this change only updates static help content, no automated tests were added.

Screenshots (UI changes only)

Before

image image

The help popup displayed a very long list of Java time zone IDs directly in the page.

After

Screenshot 2026-02-02 225457 Screenshot 2026-02-02 225509

The help popup now shows a short explanation and a link to the official time zone documentation instead of embedding the full list.

Proposed changelog entries

  • Make time zone list expandable in help.

Proposed changelog category

/label rfe,web-ui

Proposed upgrade guidelines

N/A

Submitter checklist

  • The issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate and in the imperative mood.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(...), if applicable.
  • UI changes do not introduce regressions with Content Security Policy.
  • For dependency updates, there are links to external changelogs.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jenkinsci/core-pr-reviewers

@comment-ops-bot comment-ops-bot bot added rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise labels Feb 2, 2026
@janfaracik
Copy link
Member

Could you post a Before picture? Thanks.

@AmoghParmar
Copy link
Contributor Author

Could you post a Before picture? Thanks.

Thanks @janfaracik for the suggestion!
I’ve now added a Before screenshot to the PR description so the difference between the old long time zone list and the updated help with the documentation link is clearly visible.

Please let me know if any other changes are needed.

H(0-30) 17 * * *
</pre>
<p>
The full list of supported time zone IDs depends on the Java runtime Jenkins is running on.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes this help actively unhelpful. Previously you knew exactly what was supported, now it's trial and error.

If the list is too long, wrap it in a <details> or something, so it's only shown after another click.

@daniel-beck
Copy link
Member

Fixes #60635

We migrated from Jira to GH issues. This issue used to be JENKINS-60635 and is now #20780. Please use the correct ID.

@MarkEWaite MarkEWaite changed the title JENKINS-60635 Replace long time zone list with documentation link in Build periodically help Make time zone list expandable in help Feb 3, 2026
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested interactively and the change looks good to me. I like the strong formatting on the clickable link to expand the list so that readers are more likely to see the list.

@daniel-beck daniel-beck added the squash-merge-me Unclean or useless commit history, should be merged only with squash-merge label Feb 3, 2026
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

/label ready-for-merge

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted squash-merge-me Unclean or useless commit history, should be merged only with squash-merge web-ui The PR includes WebUI changes which may need special expertise

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[JENKINS-60635] Build periodically help should offer timezones as a pop out

4 participants