-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Make time zone list expandable in help #26241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Make time zone list expandable in help #26241
Conversation
…uild periodically help
|
Could you post a Before picture? Thanks. |
Thanks @janfaracik for the suggestion! Please let me know if any other changes are needed. |
| H(0-30) 17 * * * | ||
| </pre> | ||
| <p> | ||
| The full list of supported time zone IDs depends on the Java runtime Jenkins is running on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes this help actively unhelpful. Previously you knew exactly what was supported, now it's trial and error.
If the list is too long, wrap it in a <details> or something, so it's only shown after another click.
We migrated from Jira to GH issues. This issue used to be JENKINS-60635 and is now #20780. Please use the correct ID. |
MarkEWaite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested interactively and the change looks good to me. I like the strong formatting on the clickable link to expand the list so that readers are more likely to see the list.
MarkEWaite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.
/label ready-for-merge
Fixes #20780
This pull request improves the Build periodically help documentation by replacing the extremely long in-page list of Java time zone IDs with a link to the official time zone reference.
Previously, the help popup displayed hundreds of time zone entries, making the help panel unnecessarily long and difficult to read. Most users do not need to browse the full list directly inside Jenkins. The updated help text now links to the official TZ database reference instead, keeping the help concise and more user-friendly.
Testing done
This change affects only help documentation UI and does not modify any runtime logic.
Manual testing steps:
Verified:
Since this change only updates static help content, no automated tests were added.
Screenshots (UI changes only)
Before
The help popup displayed a very long list of Java time zone IDs directly in the page.
After
The help popup now shows a short explanation and a link to the official time zone documentation instead of embedding the full list.
Proposed changelog entries
Proposed changelog category
/label rfe,web-ui
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(...), if applicable.Desired reviewers
@jenkinsci/core-pr-reviewers