Skip to content

Backporting LTS 2.541.2#26220

Merged
krisstern merged 2 commits intojenkinsci:stable-2.541from
shalinisudarsan:chore/backporting-for-2.541.2
Jan 31, 2026
Merged

Backporting LTS 2.541.2#26220
krisstern merged 2 commits intojenkinsci:stable-2.541from
shalinisudarsan:chore/backporting-for-2.541.2

Conversation

@shalinisudarsan
Copy link

@shalinisudarsan shalinisudarsan commented Jan 29, 2026

Latest core version: jenkins-2.548
Fixed:

Postponed:

Fixes #

Testing done

Screenshots (UI changes only)

Before

After

Proposed changelog entries

  • human-readable text

Proposed changelog category

/label

Proposed upgrade guidelines

N/A

Submitter checklist

  • The issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

@github-actions github-actions bot added the into-lts This PR is filed against an LTS branch label Jan 29, 2026
@timja
Copy link
Member

timja commented Jan 29, 2026

@shalinisudarsan the summary should not be pasted into backticks.
It will automatically link to issues, and show the titles if you remove them.

Are you able to update the description please

@daniel-beck
Copy link
Member

Noting #26039 (comment).

@krisstern
Copy link
Member

@shalinisudarsan the summary should not be pasted into backticks. It will automatically link to issues, and show the titles if you remove them.

Are you able to update the description please

Done

…ack end response is slow (jenkinsci#26161)

* [JENKINS-76249] Fix form submission when a dropdown changes and the web response is slow

calling renderOnDemand can cause the dom to be manipulated
aynchronouslyi due to function calls going to the Jenkins server (e.g.
stapler/bound/xxx/render).  When this occurs if there is a subsequent change to the
dropdown selection before this completes, when the HTML is finally
obtained from Jenkins it is inserted into the DOM, but it is inserted as
if it is still the selected option (ie it is not disable for the form).

renderOnDemand takes a callback function that will be called when the
DOM manipulation is complete, however the updateDropDownList did not
pass any function.

We now pass a function that manipulates the just added HTML if the
selected item is in fact no longer selected.

* Update war/src/main/webapp/scripts/hudson-behavior.js

Co-authored-by: Tim Jacomb <[email protected]>

* Apply suggestions from code review

Co-authored-by: Tim Jacomb <[email protected]>

---------

Co-authored-by: Tim Jacomb <[email protected]>
(cherry picked from commit 46a0a75)
@shalinisudarsan shalinisudarsan force-pushed the chore/backporting-for-2.541.2 branch from 8d7ce24 to 25bc490 Compare January 30, 2026 06:16
@krisstern krisstern requested a review from mawinter69 January 30, 2026 06:34
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've reviewed the changes and compared them with the two original pull requests. Changes look good.

@krisstern krisstern merged commit b8944fa into jenkinsci:stable-2.541 Jan 31, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

into-lts This PR is filed against an LTS branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants