Add help for "remove last build" in Manage Jenkins#26153
Add help for "remove last build" in Manage Jenkins#26153MarkEWaite merged 6 commits intojenkinsci:masterfrom
Conversation
MarkEWaite
left a comment
There was a problem hiding this comment.
Additional comment on the Pipeline example
core/src/main/resources/hudson/tasks/LogRotator/help-removeLastBuild.html
Outdated
Show resolved
Hide resolved
…tBuild.html Co-authored-by: Mark Waite <[email protected]>
|
@MarkEWaite Thanks for the review and the helpful guidance. I have now:
Please let me know if anything else should be adjusted. |
My suggestion used the code tag, but should have used the pre tag
You are sabotaging yourself by not doing local checks and by not reviewing the results of the automated checks performed on the pull request. Those automated checks fail the build due to a formatting error. The contributing guide tells you how to correct the formatting error.
While reviewing your change locally, I discovered that my original change proposal was wrong. I used the |
|
Now that you've developed experience adding online help to Jenkins, it would be nice if you could submit another pull request (or two) that add online help to the other parts of the build discarder. Don't do that in this pull request. It is ready to merge as far as I can tell. |
MarkEWaite
left a comment
There was a problem hiding this comment.
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.
/label ready-for-merge
* Add online help for removeLastBuild option * Format help-removeLastBuild.html with Prettier * Update core/src/main/resources/hudson/tasks/LogRotator/help-removeLastBuild.html Co-authored-by: Mark Waite <[email protected]> * Fix formatting and use correct HTML tag My suggestion used the code tag, but should have used the pre tag --------- Co-authored-by: Mark Waite <[email protected]>
Fixes #16688
This pull request adds missing online help documentation for the
“Remove last build” option of the LogRotator build discarder.
The help text explains the behavior, provides an example,
and references Pipeline usage.
Testing done
Manage Jenkins → Configure System → Build Discarder → Advanced
Screenshots (UI changes only)
Before
After
Proposed changelog entries
Proposed changelog category
/label rfe,web-ui
Proposed upgrade guidelines
N/A
Submitter checklist
Maintainer checklist
Desired reviewers
@jenkinsci/core-pr-reviewers