bug fix-offline nodes become online after saving config#26151
Closed
Kathircpe wants to merge 1 commit intojenkinsci:masterfrom
Closed
bug fix-offline nodes become online after saving config#26151Kathircpe wants to merge 1 commit intojenkinsci:masterfrom
Kathircpe wants to merge 1 commit intojenkinsci:masterfrom
Conversation
mawinter69
suggested changes
Jan 21, 2026
Contributor
mawinter69
left a comment
There was a problem hiding this comment.
This is definitely wrong.
I doubt that you have tested this properly.
| } | ||
|
|
||
| private volatile OfflineCause temporaryOfflineCause; | ||
| private transient volatile OfflineCause temporaryOfflineCause; |
Contributor
There was a problem hiding this comment.
This will not survive a Restart of Jenkins.
Contributor
|
should be closed in favor of #26154 |
Member
Agreed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26146
Testing done
Manually tested it and works.
Screenshots (UI changes only)
Before
After
Proposed changelog entries
Proposed changelog category
/label bug
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.