Skip to content

bug fix-offline nodes become online after saving config#26151

Closed
Kathircpe wants to merge 1 commit intojenkinsci:masterfrom
Kathircpe:fix/offline-nodes-becomes-online-bug
Closed

bug fix-offline nodes become online after saving config#26151
Kathircpe wants to merge 1 commit intojenkinsci:masterfrom
Kathircpe:fix/offline-nodes-becomes-online-bug

Conversation

@Kathircpe
Copy link

Fixes #26146

Testing done

Manually tested it and works.

Screenshots (UI changes only)

Before

After

Proposed changelog entries

  • Fix offline nodes become online after save config

Proposed changelog category

/label bug

Proposed upgrade guidelines

N/A

Submitter checklist

  • The issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

@comment-ops-bot comment-ops-bot bot added the bug For changelog: Minor bug. Will be listed after features label Jan 21, 2026
Copy link
Contributor

@mawinter69 mawinter69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely wrong.
I doubt that you have tested this properly.

}

private volatile OfflineCause temporaryOfflineCause;
private transient volatile OfflineCause temporaryOfflineCause;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not survive a Restart of Jenkins.

@mawinter69
Copy link
Contributor

should be closed in favor of #26154

@krisstern
Copy link
Member

should be closed in favor of #26154

Agreed

@krisstern krisstern closed this Jan 21, 2026
@Kathircpe Kathircpe deleted the fix/offline-nodes-becomes-online-bug branch January 21, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug For changelog: Minor bug. Will be listed after features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Offline nodes become online after config save or reload

3 participants